Add missing Keystone options to registration of config

This patchset adds missing Keystone options to registration
of config, including timeout, which is causing the following
error in testing:

packages/oslo_config/cfg.py", line 3130, in _get_opt_info
2018-06-12 20:28:40.318 9 ERROR armada.api     raise NoSuchOptError(opt_name, group)
2018-06-12 20:28:40.318 9 ERROR armada.api oslo_config.cfg.NoSuchOptError: no such option timeout in group [keystone_authtoken]
2018-06-12 20:28:40.318 9 ERROR armada.api

This fix is similar to a recent Shipyard patchset [0] which
aimed to solve the same issue but expands on it by following
Nova patterns here: [1].

This also updates the sample config file which now includes
the timeout option.

[0] https://review.openstack.org/#/c/572563/
[1] http://git.openstack.org/cgit/openstack/nova/tree/nova/conf/cinder.py

Change-Id: I2c35bcfe9cacbc3a443f7f0975ad2ab43c7ca7c2

armada/conf/default.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-from keystoneauth1 import loading
+from keystoneauth1 import loading as ks_loading
 from oslo_config import cfg
 
 from armada.conf import utils
@@ -94,12 +94,17 @@ path to the private key that includes the name of the key itself.""")),
 
 def register_opts(conf):
     conf.register_opts(default_options)
-    conf.register_opts(
+    ks_loading.register_auth_conf_options(conf, group='keystone_authtoken')
-        loading.get_auth_plugin_conf_options('password'),
+    ks_loading.register_session_conf_options(conf, group='keystone_authtoken')
-        group='keystone_authtoken')
 
 
 def list_opts():
     return {
         'DEFAULT': default_options,
-        'keystone_authtoken': loading.get_auth_plugin_conf_options('password')}
+        'keystone_authtoken': (
+            ks_loading.get_session_conf_options() +
+            ks_loading.get_auth_common_conf_options() +
+            ks_loading.get_auth_plugin_conf_options('password') +
+            ks_loading.get_auth_plugin_conf_options('v3password')
+        )
+    }

armada/utils/keystone.py

@@ -13,9 +13,10 @@
 # limitations under the License.
 
 from keystoneauth1 import loading
+from keystoneauth1 import session
 from oslo_config import cfg
 
 
 def get_keystone_session():
-    return loading.load_session_from_conf_options(
+    auth = loading.load_auth_from_conf_options(cfg.CONF, "keystone_authtoken")
-        cfg.CONF, group="keystone_authtoken")
+    return session.Session(auth=auth)

etc/armada/armada.conf.sample

@@ -26,27 +26,23 @@
 # The Keystone project name used for authentication. (string value)
 #project_name = admin
 
-# Path to SSH private key. (string value)
+# Optional path to an SSH private key used for authenticating against a Git
+# source repository. The path must be an absolute path to the private key that
+# includes the name of the key itself. (string value)
 #ssh_key_path = /home/user/.ssh/
 
-# Labels for the tiller pod. (string value)
+# Labels for the Tiller pod. (string value)
 #tiller_pod_labels = app=helm,name=tiller
 
-# Host for the tiller pod. (string value)
+# Namespace for the Tiller pod. (string value)
-#tiller_host = localhost
-
-# Namespace for the tiller pod. (string value)
 #tiller_namespace = kube-system
 
-# Port for the tiller pod. (integer value)
+# Port for the Tiller pod. (integer value)
 #tiller_port = 44134
 
 # IDs of approved API access roles. (list value)
 #tiller_release_roles = admin
 
-# IDs of approved API access roles. (list value)
-#tiller_status_roles = admin
-
 #
 # From oslo.log
 #
@@ -224,6 +220,29 @@
 # From armada.conf
 #
 
+# PEM encoded Certificate Authority to use when verifying HTTPs connections.
+# (string value)
+#cafile = <None>
+
+# PEM encoded client certificate cert file (string value)
+#certfile = <None>
+
+# PEM encoded client certificate key file (string value)
+#keyfile = <None>
+
+# Verify HTTPS connections. (boolean value)
+#insecure = false
+
+# Timeout value for http requests (integer value)
+#timeout = <None>
+
+# Authentication type to load (string value)
+# Deprecated group/name - [keystone_authtoken]/auth_plugin
+#auth_type = <None>
+
+# Config Section from which to load plugin specific options (string value)
+#auth_section = <None>
+
 # Authentication URL (string value)
 #auth_url = <None>
 
@@ -234,11 +253,9 @@
 #domain_name = <None>
 
 # Project ID to scope to (string value)
-# Deprecated group/name - [keystone_authtoken]/tenant_id
 #project_id = <None>
 
 # Project name to scope to (string value)
-# Deprecated group/name - [keystone_authtoken]/tenant_name
 #project_name = <None>
 
 # Domain ID containing project (string value)
@@ -260,7 +277,7 @@
 # (string value)
 #default_domain_name = <None>
 
-# User id (string value)
+# User ID (string value)
 #user_id = <None>
 
 # Username (string value)