airship/deckhand
Code Issues Proposed changes

Change .to_oslo_conf to .to_ini

Browse Source 
Currently, openstackhelm-toolkit provides two utility methods:
.to_oslo_conf and .to_ini whose only difference at this time is
the ability to handle multistring in .to_oslo_conf as it is an
openstack concept that is not found in .ini files.

As logging.conf and paste.ini do not support multistring, they do
not need to be render by .to_oslo_conf, and while the code is not
incorrect, using .to_ini would be more appropriate.

Trivial fix

Change-Id: I20ae77842a3406ea64bf40d951adef2e519cbfcb
This commit is contained in:
Tin Lam 2017-10-31 13:34:30 -05:00
parent da4b33b2a8
commit 754867a3b2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
charts/deckhand/templates/configmap-etc.yaml
View File

@ -65,8 +65,8 @@ data:
deckhand.conf: |+
{{ include "helm-toolkit.utils.to_oslo_conf" .Values.conf.deckhand | indent 4 }}
logging.conf: |+
{{ include "helm-toolkit.utils.to_oslo_conf" .Values.conf.logging | indent 4 }}
{{ include "helm-toolkit.utils.to_ini" .Values.conf.logging | indent 4 }}
deckhand-paste.ini: |+
{{ include "helm-toolkit.utils.to_oslo_conf" .Values.conf.paste | indent 4 }}
{{ include "helm-toolkit.utils.to_ini" .Values.conf.paste | indent 4 }}
policy.yaml: |+
{{ toYaml .Values.conf.policy | indent 4 }}