airship/deckhand
Code Issues Proposed changes

trivial: Add orientation='reverse' to find_cycle in layering

Browse Source 
This patchset adds orientation='reverse' when looking for
substitution cycles in the layering module in order to work
with newer versions of networkx which throw:

networkx.exception.NetworkXUnfeasible: Graph contains a cycle.

This corrects the issue.

Change-Id: I854a10ed524daf45bef9ad856938ffedb3e76baf
This commit is contained in:
Felipe Monteiro 2018-06-29 18:30:16 -04:00
parent 108ac7c216
commit 8c37ac7f60
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
deckhand/engine/layering.py
View File

@ -337,7 +337,7 @@ class DocumentLayering(object):
g.add_edge(document.meta, src.meta) g.add_edge(document.meta, src.meta)
try: try:
cycle = find_cycle(g) cycle = find_cycle(g, orientation='reverse')
except networkx.exception.NetworkXNoCycle: except networkx.exception.NetworkXNoCycle:
pass pass
else: else: