airship/spyglass-plugin-xls
Code Issues Proposed changes

Fix circular Spyglass dependency

Browse Source 
Adding PBR into spyglass-plugin-xls has caused a circular dependency.
Because Spyglass installs spyglass-plugin-xls it also now tries to
resolve spyglass-plugin-xls's requirements.txt which in turn requires
Spyglass to be installed. Since Spyglass is what's currently trying to
install, pip fails to resolve the plugin's dependencies. This change
moves the Spyglass requirement into test-requirements.txt. Spyglass will
always install this plugin so spyglass-plugin-xls should only need to
install Spyglass to run its own independent tests.

Change-Id: Ia5765d6b894cc1073c8be803d43f0b90cc448383
This commit is contained in:
Ian H. Pittwood 2019-06-17 09:14:37 -05:00 committed by Ian Pittwood
parent c0ba5e77b8
commit ec863a4f16
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
requirements.txt
View File

@ -1,5 +1,3 @@
click==7.0
PyYAML==5.1.1
openpyxl==2.6.2
git+https://opendev.org/airship/spyglass.git#egg=spyglass

3
test-requirements.txt
View File

@ -6,3 +6,6 @@ hacking==1.1.0
# Security
bandit==1.6.0
# Installs Spyglass for independent tests, but not in requirements.txt since Spyglass will always install this plugin
git+https://opendev.org/airship/spyglass.git#egg=spyglass