From 027f0b2895a4f5fbf879d02f43ab1bb0489bd938 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Fri, 10 Jul 2020 10:42:01 +0200 Subject: [PATCH 008/108] virSecurityManagerMetadataLock: Clarify directory locking comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In the light of recent commit of 9d83281382 fix the comment that says directories can't be locked. Well, in general they can, but not in our case. Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko (cherry picked from commit 0a145de970af31e605d837c3502855fe93aaec9a) --- src/security/security_manager.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/security/security_manager.c b/src/security/security_manager.c index 5159abd92d..9d5dfec12b 100644 --- a/src/security/security_manager.c +++ b/src/security/security_manager.c @@ -1331,7 +1331,8 @@ virSecurityManagerMetadataLock(virSecurityManagerPtr mgr G_GNUC_UNUSED, continue; if (S_ISDIR(sb.st_mode)) { - /* Directories can't be locked */ + /* We need to open the path for writing because we need exclusive + * (write) lock. But directories can't be opened for writing. */ continue; } -- 2.33.0