From 59d5adb4620c57743d88dda8e1ac2d20ce7bd9d3 Mon Sep 17 00:00:00 2001 From: wangmeiyang Date: Wed, 30 Nov 2022 20:17:09 +0800 Subject: [PATCH 21/24] virsh: domain: fix mistake in cmdMigrateSetMaxDowntime() If there was added a new return value indicating success to the function virDomainMigrateSetMaxDowntime() in the future, because of the way the function is called it would be treated it as an error state and would return false (indicating failure). This patch fixes it, so that the call of the function follows the same pattern as is currently set in libvirt. cherry-pick from 0987edbedf96fc920a73213fdad1ad9a119cbee7 Signed-off-by: Kristina Hanicova Signed-off-by: Meiyang Wang Reviewed-by: Michal Privoznik --- tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index c043ad3ce5..6dd56168e3 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11221,7 +11221,7 @@ cmdMigrateSetMaxDowntime(vshControl *ctl, const vshCmd *cmd) goto done; } - if (virDomainMigrateSetMaxDowntime(dom, downtime, 0)) + if (virDomainMigrateSetMaxDowntime(dom, downtime, 0) < 0) goto done; ret = true; -- 2.27.0