From ff99b327473454e3be7a89554ccbae856bcb7e3b Mon Sep 17 00:00:00 2001 From: jianchunfu Date: Mon, 5 Dec 2022 16:09:13 +0800 Subject: [PATCH 17/17] hw/display/qxl: Assert memory slot fits in preallocated MemoryRegion MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Assert memory slot fits in preallocated MemoryRegion. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi Signed-off-by: jianchunfu --- hw/display/qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 2a4b2d4158..bcd9e8716a 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -1372,6 +1372,7 @@ static int qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t delta, qxl_set_guest_bug(d, "%s: pci_region = %d", __func__, pci_region); return 1; } + assert(guest_end - pci_start <= memory_region_size(mr)); virt_start = (intptr_t)memory_region_get_ram_ptr(mr); memslot.slot_id = slot_id; -- 2.27.0