35 lines
1.2 KiB
Diff
35 lines
1.2 KiB
Diff
From d1c3b60ebbfe0fad5372cf2940b366f00548a4fe Mon Sep 17 00:00:00 2001
|
|
From: tangbinzy <tangbin_yewu@cmss.chinamobile.com>
|
|
Date: Wed, 23 Nov 2022 10:00:57 +0000
|
|
Subject: [PATCH 07/23] qemu: fix memleak in qemuDomainAttachDeviceLive()
|
|
During disk hot plugging, qemuDomainAttachDeviceLive() adds the new disk to
|
|
the device list of the VM object. However, hot plugging cdroms and floppies
|
|
only updates the src variable of the original disk device, so the newly
|
|
generated disk object needs to be freed.
|
|
|
|
Signed-off-by: Jin Yan <jinyan12@huawei.com>
|
|
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
|
|
|
|
Signed-off-by: tangbin <tangbin_yewu@cmss.chinamobile.com>
|
|
(cherry-pick from 2f470a4fb1edbe2da702e398314b9db201bb991e)
|
|
---
|
|
src/qemu/qemu_hotplug.c | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
|
|
index d7bcb6a99f..c9347bac04 100644
|
|
--- a/src/qemu/qemu_hotplug.c
|
|
+++ b/src/qemu/qemu_hotplug.c
|
|
@@ -1115,6 +1115,7 @@ qemuDomainAttachDeviceDiskLive(virQEMUDriverPtr driver,
|
|
return -1;
|
|
|
|
disk->src = NULL;
|
|
+ virDomainDiskDefFree(disk);
|
|
return 0;
|
|
}
|
|
|
|
--
|
|
2.27.0
|
|
|