79c4324644
Change-Id: I2d302dda68298877c65c99147f5bf22186a59aac
164 lines
5.4 KiB
Diff
164 lines
5.4 KiB
Diff
From 529074fd45a543a9259441e02652c3ac60673d07 Mon Sep 17 00:00:00 2001
|
|
From: fangyi <eric.fangyi@huawei.com>
|
|
Date: Wed, 22 Nov 2023 09:53:34 +0800
|
|
Subject: [PATCH] Revert "vhost: add support for configure interrupt"
|
|
|
|
This reverts commit f7220a7ce21604a4bc6260ccca4dc9068c1f27f2.
|
|
|
|
Fixes: f7220a7ce2 ("vhost: add support for configure interrupt")
|
|
Cc: "Cindy Lu" <lulu@redhat.com>
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Signed-off-by: fangyi <eric.fangyi@huawei.com>
|
|
---
|
|
hw/virtio/vhost.c | 76 ---------------------------------------
|
|
include/hw/virtio/vhost.h | 4 ---
|
|
2 files changed, 80 deletions(-)
|
|
|
|
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
|
|
index caa53443ab..2f9bb96d63 100644
|
|
--- a/hw/virtio/vhost.c
|
|
+++ b/hw/virtio/vhost.c
|
|
@@ -1581,67 +1581,6 @@ void vhost_virtqueue_mask(struct vhost_dev *hdev, VirtIODevice *vdev, int n,
|
|
}
|
|
}
|
|
|
|
-bool vhost_config_pending(struct vhost_dev *hdev)
|
|
-{
|
|
- assert(hdev->vhost_ops);
|
|
- if ((hdev->started == false) ||
|
|
- (hdev->vhost_ops->vhost_set_config_call == NULL)) {
|
|
- return false;
|
|
- }
|
|
-
|
|
- EventNotifier *notifier =
|
|
- &hdev->vqs[VHOST_QUEUE_NUM_CONFIG_INR].masked_config_notifier;
|
|
- return event_notifier_test_and_clear(notifier);
|
|
-}
|
|
-
|
|
-void vhost_config_mask(struct vhost_dev *hdev, VirtIODevice *vdev, bool mask)
|
|
-{
|
|
- int fd;
|
|
- int r;
|
|
- EventNotifier *notifier =
|
|
- &hdev->vqs[VHOST_QUEUE_NUM_CONFIG_INR].masked_config_notifier;
|
|
- EventNotifier *config_notifier = &vdev->config_notifier;
|
|
- assert(hdev->vhost_ops);
|
|
-
|
|
- if ((hdev->started == false) ||
|
|
- (hdev->vhost_ops->vhost_set_config_call == NULL)) {
|
|
- return;
|
|
- }
|
|
- if (mask) {
|
|
- assert(vdev->use_guest_notifier_mask);
|
|
- fd = event_notifier_get_fd(notifier);
|
|
- } else {
|
|
- fd = event_notifier_get_fd(config_notifier);
|
|
- }
|
|
- r = hdev->vhost_ops->vhost_set_config_call(hdev, fd);
|
|
- if (r < 0) {
|
|
- VHOST_OPS_DEBUG(r, "vhost_set_config_call failed");
|
|
- }
|
|
-}
|
|
-
|
|
-static void vhost_stop_config_intr(struct vhost_dev *dev)
|
|
-{
|
|
- int fd = -1;
|
|
- assert(dev->vhost_ops);
|
|
- if (dev->vhost_ops->vhost_set_config_call) {
|
|
- dev->vhost_ops->vhost_set_config_call(dev, fd);
|
|
- }
|
|
-}
|
|
-
|
|
-static void vhost_start_config_intr(struct vhost_dev *dev)
|
|
-{
|
|
- int r;
|
|
-
|
|
- assert(dev->vhost_ops);
|
|
- int fd = event_notifier_get_fd(&dev->vdev->config_notifier);
|
|
- if (dev->vhost_ops->vhost_set_config_call) {
|
|
- r = dev->vhost_ops->vhost_set_config_call(dev, fd);
|
|
- if (!r) {
|
|
- event_notifier_set(&dev->vdev->config_notifier);
|
|
- }
|
|
- }
|
|
-}
|
|
-
|
|
uint64_t vhost_get_features(struct vhost_dev *hdev, const int *feature_bits,
|
|
uint64_t features)
|
|
{
|
|
@@ -1854,16 +1793,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
|
|
}
|
|
}
|
|
|
|
- r = event_notifier_init(
|
|
- &hdev->vqs[VHOST_QUEUE_NUM_CONFIG_INR].masked_config_notifier, 0);
|
|
- if (r < 0) {
|
|
- return r;
|
|
- }
|
|
- event_notifier_test_and_clear(
|
|
- &hdev->vqs[VHOST_QUEUE_NUM_CONFIG_INR].masked_config_notifier);
|
|
- if (!vdev->use_guest_notifier_mask) {
|
|
- vhost_config_mask(hdev, vdev, true);
|
|
- }
|
|
if (hdev->log_enabled) {
|
|
uint64_t log_base;
|
|
|
|
@@ -1896,7 +1825,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
|
|
vhost_device_iotlb_miss(hdev, vq->used_phys, true);
|
|
}
|
|
}
|
|
- vhost_start_config_intr(hdev);
|
|
return 0;
|
|
fail_log:
|
|
vhost_log_put(hdev, false);
|
|
@@ -1922,9 +1850,6 @@ void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev)
|
|
|
|
/* should only be called after backend is connected */
|
|
assert(hdev->vhost_ops);
|
|
- event_notifier_test_and_clear(
|
|
- &hdev->vqs[VHOST_QUEUE_NUM_CONFIG_INR].masked_config_notifier);
|
|
- event_notifier_test_and_clear(&vdev->config_notifier);
|
|
|
|
if (hdev->vhost_ops->vhost_dev_start) {
|
|
hdev->vhost_ops->vhost_dev_start(hdev, false);
|
|
@@ -1942,7 +1867,6 @@ void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev)
|
|
}
|
|
memory_listener_unregister(&hdev->iommu_listener);
|
|
}
|
|
- vhost_stop_config_intr(hdev);
|
|
vhost_log_put(hdev, true);
|
|
hdev->started = false;
|
|
hdev->vdev = NULL;
|
|
diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h
|
|
index 2ae5c3bfd8..86f36f0106 100644
|
|
--- a/include/hw/virtio/vhost.h
|
|
+++ b/include/hw/virtio/vhost.h
|
|
@@ -29,7 +29,6 @@ struct vhost_virtqueue {
|
|
unsigned long long used_phys;
|
|
unsigned used_size;
|
|
EventNotifier masked_notifier;
|
|
- EventNotifier masked_config_notifier;
|
|
struct vhost_dev *dev;
|
|
};
|
|
|
|
@@ -38,7 +37,6 @@ typedef unsigned long vhost_log_chunk_t;
|
|
#define VHOST_LOG_BITS (8 * sizeof(vhost_log_chunk_t))
|
|
#define VHOST_LOG_CHUNK (VHOST_LOG_PAGE * VHOST_LOG_BITS)
|
|
#define VHOST_INVALID_FEATURE_BIT (0xff)
|
|
-#define VHOST_QUEUE_NUM_CONFIG_INR 0
|
|
|
|
struct vhost_log {
|
|
unsigned long long size;
|
|
@@ -118,8 +116,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev);
|
|
void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev);
|
|
int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev);
|
|
void vhost_dev_disable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev);
|
|
-bool vhost_config_pending(struct vhost_dev *hdev);
|
|
-void vhost_config_mask(struct vhost_dev *hdev, VirtIODevice *vdev, bool mask);
|
|
|
|
/* Test and clear masked event pending status.
|
|
* Should be called after unmask to avoid losing events.
|
|
--
|
|
2.27.0
|
|
|