40 lines
1.2 KiB
Diff
40 lines
1.2 KiB
Diff
From d5ad002a22aade5086722fd9aa2addf2f95e52c3 Mon Sep 17 00:00:00 2001
|
|
From: wangjinlei <wangjinlei_yewu@cmss.chinamobile.com>
|
|
Date: Thu, 24 Nov 2022 19:39:33 +0800
|
|
Subject: [PATCH 27/29] configure: Check mkdir result directly, not via $?
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Shellcheck warns that we have one place where we run a command and
|
|
then check if it failed using $?; this is better written to simply
|
|
check the command in the 'if' statement directly.
|
|
|
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
|
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
|
|
Message-id: 20220825150703.4074125-7-peter.maydell@linaro.org
|
|
|
|
Signed-off-by: wangjinlei <wangjinlei_yewu@cmss.chinamobile.com>
|
|
---
|
|
configure | 3 +--
|
|
1 file changed, 1 insertion(+), 2 deletions(-)
|
|
|
|
diff --git a/configure b/configure
|
|
index 8cbf186296..561c86c913 100755
|
|
--- a/configure
|
|
+++ b/configure
|
|
@@ -67,8 +67,7 @@ fi
|
|
# it when configure exits.)
|
|
TMPDIR1="config-temp"
|
|
rm -rf "${TMPDIR1}"
|
|
-mkdir -p "${TMPDIR1}"
|
|
-if [ $? -ne 0 ]; then
|
|
+if ! mkdir -p "${TMPDIR1}"; then
|
|
echo "ERROR: failed to create temporary directory"
|
|
exit 1
|
|
fi
|
|
--
|
|
2.27.0
|
|
|