39 lines
1.4 KiB
Diff
39 lines
1.4 KiB
Diff
From 98c106af8a2f761f615690494b425aed57b308db Mon Sep 17 00:00:00 2001
|
|
From: Mauro Matteo Cascella <mcascell@redhat.com>
|
|
Date: Thu, 7 Apr 2022 10:11:06 +0200
|
|
Subject: [PATCH 1/2] display/qxl-render: fix race condition in qxl_cursor
|
|
(CVE-2021-4207)
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Avoid fetching 'width' and 'height' a second time to prevent possible
|
|
race condition. Refer to security advisory
|
|
https://starlabs.sg/advisories/22-4207/ for more information.
|
|
|
|
Fixes: CVE-2021-4207
|
|
Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
|
|
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
Message-Id: <20220407081106.343235-1-mcascell@redhat.com>
|
|
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
---
|
|
hw/display/qxl-render.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c
|
|
index d28849b121..237ed293ba 100644
|
|
--- a/hw/display/qxl-render.c
|
|
+++ b/hw/display/qxl-render.c
|
|
@@ -266,7 +266,7 @@ static QEMUCursor *qxl_cursor(PCIQXLDevice *qxl, QXLCursor *cursor,
|
|
}
|
|
break;
|
|
case SPICE_CURSOR_TYPE_ALPHA:
|
|
- size = sizeof(uint32_t) * cursor->header.width * cursor->header.height;
|
|
+ size = sizeof(uint32_t) * c->width * c->height;
|
|
qxl_unpack_chunks(c->data, size, qxl, &cursor->chunk, group_id);
|
|
if (qxl->debug > 2) {
|
|
cursor_print_ascii_art(c, "qxl/alpha");
|
|
--
|
|
2.27.0
|
|
|