36 lines
1.3 KiB
Diff
36 lines
1.3 KiB
Diff
From 38a72d2fbaf732d0804fefca034c24b2ad068ad1 Mon Sep 17 00:00:00 2001
|
|
From: Konstantin Kostiuk <kkostiuk@redhat.com>
|
|
Date: Fri, 3 Mar 2023 21:20:07 +0200
|
|
Subject: [PATCH] qga/win32: Remove change action from MSI installer
|
|
|
|
Remove the 'change' button from "Programs and Features" because it does
|
|
not checks if a user is an admin or not. The installer has no components
|
|
to choose from and always installs everything. So the 'change' button is
|
|
not obviously needed but can create a security issue.
|
|
|
|
resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2167423
|
|
fixes: CVE-2023-0664 (part 1 of 2)
|
|
|
|
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
|
|
Reviewed-by: Yan Vugenfirer <yvugenfi@redhat.com>
|
|
Reported-by: Brian Wiltse <brian.wiltse@live.com>
|
|
---
|
|
qga/installer/qemu-ga.wxs | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
|
|
index 0950e8c6be..b62e709a4c 100644
|
|
--- a/qga/installer/qemu-ga.wxs
|
|
+++ b/qga/installer/qemu-ga.wxs
|
|
@@ -58,6 +58,7 @@
|
|
/>
|
|
<Media Id="1" Cabinet="qemu_ga.$(env.QEMU_GA_VERSION).cab" EmbedCab="yes" />
|
|
<Property Id="WHSLogo">1</Property>
|
|
+ <Property Id="ARPNOMODIFY" Value="yes" Secure="yes" />
|
|
<MajorUpgrade
|
|
DowngradeErrorMessage="Error: A newer version of QEMU guest agent is already installed."
|
|
/>
|
|
--
|
|
2.41.0.windows.1
|
|
|