90 lines
3.0 KiB
Diff
90 lines
3.0 KiB
Diff
From 29048bdf8848d527b39a383c7f0c4f8c60870f71 Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= <eperezma@redhat.com>
|
|
Date: Wed, 20 Jul 2022 08:59:44 +0200
|
|
Subject: [PATCH] vdpa: Extract get features part from
|
|
vhost_vdpa_get_max_queue_pairs
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
To know the device features is needed for CVQ SVQ, so SVQ knows if it
|
|
can handle all commands or not. Extract from
|
|
vhost_vdpa_get_max_queue_pairs so we can reuse it.
|
|
|
|
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
|
|
Acked-by: Jason Wang <jasowang@redhat.com>
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Signed-off-by: Jason Wang <jasowang@redhat.com>
|
|
Signed-off-by: fangyi <eric.fangyi@huawei.com>
|
|
---
|
|
net/vhost-vdpa.c | 30 ++++++++++++++++++++----------
|
|
1 file changed, 20 insertions(+), 10 deletions(-)
|
|
|
|
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
|
|
index 2d928feefb..6a0fcab443 100644
|
|
--- a/net/vhost-vdpa.c
|
|
+++ b/net/vhost-vdpa.c
|
|
@@ -482,20 +482,24 @@ static NetClientState *net_vhost_vdpa_init(NetClientState *peer,
|
|
return nc;
|
|
}
|
|
|
|
-static int vhost_vdpa_get_max_queue_pairs(int fd, int *has_cvq, Error **errp)
|
|
+static int vhost_vdpa_get_features(int fd, uint64_t *features, Error **errp)
|
|
+{
|
|
+ int ret = ioctl(fd, VHOST_GET_FEATURES, features);
|
|
+ if (unlikely(ret < 0)) {
|
|
+ error_setg_errno(errp, errno,
|
|
+ "Fail to query features from vhost-vDPA device");
|
|
+ }
|
|
+ return ret;
|
|
+}
|
|
+
|
|
+static int vhost_vdpa_get_max_queue_pairs(int fd, uint64_t features,
|
|
+ int *has_cvq, Error **errp)
|
|
{
|
|
unsigned long config_size = offsetof(struct vhost_vdpa_config, buf);
|
|
g_autofree struct vhost_vdpa_config *config = NULL;
|
|
__virtio16 *max_queue_pairs;
|
|
- uint64_t features;
|
|
int ret;
|
|
|
|
- ret = ioctl(fd, VHOST_GET_FEATURES, &features);
|
|
- if (ret) {
|
|
- error_setg(errp, "Fail to query features from vhost-vDPA device");
|
|
- return ret;
|
|
- }
|
|
-
|
|
if (features & (1 << VIRTIO_NET_F_CTRL_VQ)) {
|
|
*has_cvq = 1;
|
|
} else {
|
|
@@ -525,10 +529,11 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
|
|
NetClientState *peer, Error **errp)
|
|
{
|
|
const NetdevVhostVDPAOptions *opts;
|
|
+ uint64_t features;
|
|
int vdpa_device_fd;
|
|
g_autofree NetClientState **ncs = NULL;
|
|
NetClientState *nc;
|
|
- int queue_pairs, i, has_cvq = 0;
|
|
+ int queue_pairs, r, i, has_cvq = 0;
|
|
|
|
assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA);
|
|
opts = &netdev->u.vhost_vdpa;
|
|
@@ -542,7 +547,12 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
|
|
return -errno;
|
|
}
|
|
|
|
- queue_pairs = vhost_vdpa_get_max_queue_pairs(vdpa_device_fd,
|
|
+ r = vhost_vdpa_get_features(vdpa_device_fd, &features, errp);
|
|
+ if (unlikely(r < 0)) {
|
|
+ return r;
|
|
+ }
|
|
+
|
|
+ queue_pairs = vhost_vdpa_get_max_queue_pairs(vdpa_device_fd, features,
|
|
&has_cvq, errp);
|
|
if (queue_pairs < 0) {
|
|
qemu_close(vdpa_device_fd);
|
|
--
|
|
2.27.0
|
|
|