38 lines
1.5 KiB
Diff
38 lines
1.5 KiB
Diff
From d57f2527fd747d2b51ad18dc38fa9d0c25ebc8a7 Mon Sep 17 00:00:00 2001
|
|
From: Kunkun Jiang <jiangkunkun@huawei.com>
|
|
Date: Mon, 11 Jul 2022 09:46:51 +0800
|
|
Subject: [PATCH 2/3] vfio/migration: Fix incorrect initialization value for
|
|
parameters in VFIOMigration
|
|
|
|
The structure VFIOMigration of a VFIODevice is allocated and initialized
|
|
in vfio_migration_init(). "device_state" and "vm_running" are initialized
|
|
to 0, indicating that VFIO device is_STOP and VM is not-running. The
|
|
initialization value is incorrect. According to the agreement, default
|
|
state of VFIO device is _RUNNING. And if a VFIO device is hot-plugged
|
|
while the VM is running, "vm_running" should be 1. This patch fixes it.
|
|
|
|
Fixes: 02a7e71b1e5b ("vfio: Add VM state change handler to know state of VM")
|
|
Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>
|
|
Link: https://lore.kernel.org/r/20220711014651.1327-1-jiangkunkun@huawei.com
|
|
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
|
|
---
|
|
hw/vfio/migration.c | 2 ++
|
|
1 file changed, 2 insertions(+)
|
|
|
|
diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
|
|
index ff6b45de6b..e69b5f2e42 100644
|
|
--- a/hw/vfio/migration.c
|
|
+++ b/hw/vfio/migration.c
|
|
@@ -805,6 +805,8 @@ static int vfio_migration_init(VFIODevice *vbasedev,
|
|
}
|
|
|
|
vbasedev->migration = g_new0(VFIOMigration, 1);
|
|
+ vbasedev->migration->device_state = VFIO_DEVICE_STATE_RUNNING;
|
|
+ vbasedev->migration->vm_running = runstate_is_running();
|
|
|
|
ret = vfio_region_setup(obj, vbasedev, &vbasedev->migration->region,
|
|
info->index, "migration");
|
|
--
|
|
2.27.0
|
|
|