38 lines
1.5 KiB
Diff
38 lines
1.5 KiB
Diff
From 5a69ce95a920377f1c4f0c34c6cb8073dc5dbf8d Mon Sep 17 00:00:00 2001
|
|
From: qihao <qihao_yewu@cmss.chinamobile.com>
|
|
Date: Mon, 26 Jun 2023 14:29:40 +0800
|
|
Subject: [PATCH] virtio-gpu: add a FIXME for virtio_gpu_load()
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
cheery-pick from 529969b8d03970bae5feef8c69ebf5e0f521131c
|
|
|
|
It looks like the virtio_gpu_load() does not compute and set the offset,
|
|
the same way virtio_gpu_set_scanout() does. This probably results in
|
|
incorrect display until the scanout/framebuffer is updated again, I
|
|
guess we should fix it, although I haven't checked this yet.
|
|
|
|
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
Message-Id: <20230515132518.1025853-1-marcandre.lureau@redhat.com>
|
|
Signed-off-by: qihao_yewu <qihao_yewu@cmss.chinamobile.com>
|
|
---
|
|
hw/display/virtio-gpu.c | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
|
|
index c6dc818988..9ccc0575e3 100644
|
|
--- a/hw/display/virtio-gpu.c
|
|
+++ b/hw/display/virtio-gpu.c
|
|
@@ -1284,6 +1284,7 @@ static int virtio_gpu_load(QEMUFile *f, void *opaque, size_t size,
|
|
/* load & apply scanout state */
|
|
vmstate_load_state(f, &vmstate_virtio_gpu_scanouts, g, 1);
|
|
for (i = 0; i < g->parent_obj.conf.max_outputs; i++) {
|
|
+ /* FIXME: should take scanout.r.{x,y} into account */
|
|
scanout = &g->parent_obj.scanout[i];
|
|
if (!scanout->resource_id) {
|
|
continue;
|
|
--
|
|
2.41.0.windows.1
|
|
|