opendev/elastic-recheck
Code Issues Proposed changes

Don't include recheck instructions when unclassified failures

Browse Source 
If there is an unclassified failure in the check queue, we want to make
it clear to the user so they will investigate the error as its most
likely a valid failure. Also don't include recheck instructions when
unclassified failure as they shouldn't be running a recheck if there is
an unclassified failure.

With us now classifying many failures from non-voting jobs, it is common
to see classified failures and no mention of the job that legitimately
failed.

Partial revert of I52044afb4f3a1bf3f22ba4c0e8d38d76271ffc00

Change-Id: I6b471b9ab9c7f36eeed93993ea086bbc9daa56b0
This commit is contained in:
Joe Gordon 2014-04-01 21:21:44 -07:00
parent 56ea8f9fd3
commit 14bfee5646
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
elastic_recheck/elasticRecheck.py
View File

@ -134,9 +134,7 @@ class FailEvent(object):
bug_map = {}
for job in self.failed_jobs:
if len(job.bugs) is 0:
# we only care about fails with missing bugs in the gate
if self.queue() == "gate":
bug_map[job.name] = None
bug_map[job.name] = None
else:
bug_map[job.name] = ' '.join(self.bug_urls(job.bugs))
bug_list = []
@ -150,10 +148,6 @@ class FailEvent(object):
def is_fully_classified(self):
if self.get_all_bugs() is None:
return True
# we consider anything that's not in the gate queue
# fully classified, because errors are expected
if self.queue() != "gate":
return True
for job in self.failed_jobs:
if len(job.bugs) is 0:
return False

5
elastic_recheck/tests/unit/test_stream.py
View File

@ -178,10 +178,11 @@ class TestStream(tests.TestCase):
self.assertEqual(event.bug_urls(),
['https://bugs.launchpad.net/bugs/123456'])
self.assertEqual(event.bug_urls_map(),
['gate-keystone-python26: '
['gate-keystone-python27: unrecognized error',
'gate-keystone-python26: '
'https://bugs.launchpad.net/bugs/123456'])
self.assertEqual(sorted(event.failed_job_names()),
['gate-keystone-python26',
'gate-keystone-python27'])
self.assertEqual(event.get_all_bugs(), ['123456'])
self.assertTrue(event.is_fully_classified())
self.assertFalse(event.is_fully_classified())