opendev/engagement
Code Issues Proposed changes

Only paginate queries by integer values

Browse Source 
In order to avoid a bug where overlap page calculations could result
in requesting a fractional offset, coerce the value to an integer.

Change-Id: I22f9b444bf0965bf3146f3238a2afdf6d9860248
This commit is contained in:
Jeremy Stanley 2023-12-22 14:07:47 +00:00
parent 95e53e0c73
commit 76ceb2f2b9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engagement/stats.py
View File

@ -384,7 +384,7 @@ def main(verbose=0):
# Offset additional pages by half the returned entry count to help # Offset additional pages by half the returned entry count to help
# avoid missing changes due to pagination instability # avoid missing changes due to pagination instability
if new_changes and new_changes[-1].get('_more_changes', False): if new_changes and new_changes[-1].get('_more_changes', False):
offset += len(new_changes)/2 offset += int(len(new_changes)/2)
else: else:
offset = -1 offset = -1