opendev/gerrit
Code Issues Proposed changes

Switch remote JSON services to use JSON-RPC 2.0

Browse Source 
Change-Id: I86a432695779e793247ff0716fcfec34dd11885e
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce 2009-12-12 19:28:58 -08:00
parent 1a40be0f15
commit 1616335fa4
13 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-common/src/main/java/com/google/gerrit/common/auth/openid/OpenIdService.java
View File

@ -18,7 +18,10 @@ import com.google.gerrit.common.auth.SignInMode;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.AllowCrossSiteRequest; import com.google.gwtjsonrpc.client.AllowCrossSiteRequest;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
@RpcImpl(version = Version.V2_0)
public interface OpenIdService extends RemoteJsonService { public interface OpenIdService extends RemoteJsonService {
@AllowCrossSiteRequest @AllowCrossSiteRequest
void discover(String openidIdentifier, SignInMode mode, void discover(String openidIdentifier, SignInMode mode,

3
gerrit-common/src/main/java/com/google/gerrit/common/auth/userpass/UserPassAuthService.java
View File

@ -17,7 +17,10 @@ package com.google.gerrit.common.auth.userpass;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.AllowCrossSiteRequest; import com.google.gwtjsonrpc.client.AllowCrossSiteRequest;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
@RpcImpl(version = Version.V2_0)
public interface UserPassAuthService extends RemoteJsonService { public interface UserPassAuthService extends RemoteJsonService {
@AllowCrossSiteRequest @AllowCrossSiteRequest
void authenticate(String username, String password, void authenticate(String username, String password,

3
gerrit-common/src/main/java/com/google/gerrit/common/data/AccountSecurity.java
View File

@ -23,11 +23,14 @@ import com.google.gerrit.reviewdb.ContactInformation;
import com.google.gerrit.reviewdb.ContributorAgreement; import com.google.gerrit.reviewdb.ContributorAgreement;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.VoidResult; import com.google.gwtjsonrpc.client.VoidResult;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
import java.util.List; import java.util.List;
import java.util.Set; import java.util.Set;
@RpcImpl(version = Version.V2_0)
public interface AccountSecurity extends RemoteJsonService { public interface AccountSecurity extends RemoteJsonService {
@SignInRequired @SignInRequired
void mySshKeys(AsyncCallback<List<AccountSshKey>> callback); void mySshKeys(AsyncCallback<List<AccountSshKey>> callback);

3
gerrit-common/src/main/java/com/google/gerrit/common/data/AccountService.java
View File

@ -20,11 +20,14 @@ import com.google.gerrit.reviewdb.AccountGeneralPreferences;
import com.google.gerrit.reviewdb.AccountProjectWatch; import com.google.gerrit.reviewdb.AccountProjectWatch;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.VoidResult; import com.google.gwtjsonrpc.client.VoidResult;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
import java.util.List; import java.util.List;
import java.util.Set; import java.util.Set;
@RpcImpl(version = Version.V2_0)
public interface AccountService extends RemoteJsonService { public interface AccountService extends RemoteJsonService {
@SignInRequired @SignInRequired
void myAccount(AsyncCallback<Account> callback); void myAccount(AsyncCallback<Account> callback);

3
gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeDetailService.java
View File

@ -19,7 +19,10 @@ import com.google.gerrit.reviewdb.Change;
import com.google.gerrit.reviewdb.PatchSet; import com.google.gerrit.reviewdb.PatchSet;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
@RpcImpl(version = Version.V2_0)
public interface ChangeDetailService extends RemoteJsonService { public interface ChangeDetailService extends RemoteJsonService {
void changeDetail(Change.Id id, AsyncCallback<ChangeDetail> callback); void changeDetail(Change.Id id, AsyncCallback<ChangeDetail> callback);

3
gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeListService.java
View File

@ -20,10 +20,13 @@ import com.google.gerrit.reviewdb.Change;
import com.google.gerrit.reviewdb.Project; import com.google.gerrit.reviewdb.Project;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.VoidResult; import com.google.gwtjsonrpc.client.VoidResult;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
import java.util.Set; import java.util.Set;
@RpcImpl(version = Version.V2_0)
public interface ChangeListService extends RemoteJsonService { public interface ChangeListService extends RemoteJsonService {
/** Get all open changes more recent than pos, fetching at most limit rows. */ /** Get all open changes more recent than pos, fetching at most limit rows. */
void allOpenPrev(String pos, int limit, void allOpenPrev(String pos, int limit,

3
gerrit-common/src/main/java/com/google/gerrit/common/data/ChangeManageService.java
View File

@ -18,7 +18,10 @@ import com.google.gerrit.common.auth.SignInRequired;
import com.google.gerrit.reviewdb.PatchSet; import com.google.gerrit.reviewdb.PatchSet;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
@RpcImpl(version = Version.V2_0)
public interface ChangeManageService extends RemoteJsonService { public interface ChangeManageService extends RemoteJsonService {
@SignInRequired @SignInRequired
void submit(PatchSet.Id patchSetId, AsyncCallback<ChangeDetail> callback); void submit(PatchSet.Id patchSetId, AsyncCallback<ChangeDetail> callback);

3
gerrit-common/src/main/java/com/google/gerrit/common/data/GroupAdminService.java
View File

@ -19,11 +19,14 @@ import com.google.gerrit.reviewdb.AccountGroup;
import com.google.gerrit.reviewdb.AccountGroupMember; import com.google.gerrit.reviewdb.AccountGroupMember;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.VoidResult; import com.google.gwtjsonrpc.client.VoidResult;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
import java.util.List; import java.util.List;
import java.util.Set; import java.util.Set;
@RpcImpl(version = Version.V2_0)
public interface GroupAdminService extends RemoteJsonService { public interface GroupAdminService extends RemoteJsonService {
@SignInRequired @SignInRequired
void ownedGroups(AsyncCallback<List<AccountGroup>> callback); void ownedGroups(AsyncCallback<List<AccountGroup>> callback);

3
gerrit-common/src/main/java/com/google/gerrit/common/data/PatchDetailService.java
View File

@ -24,11 +24,14 @@ import com.google.gerrit.reviewdb.PatchSet;
import com.google.gerrit.reviewdb.Patch.Key; import com.google.gerrit.reviewdb.Patch.Key;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.VoidResult; import com.google.gwtjsonrpc.client.VoidResult;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
import java.util.List; import java.util.List;
import java.util.Set; import java.util.Set;
@RpcImpl(version = Version.V2_0)
public interface PatchDetailService extends RemoteJsonService { public interface PatchDetailService extends RemoteJsonService {
void patchScript(Patch.Key key, PatchSet.Id a, PatchSet.Id b, void patchScript(Patch.Key key, PatchSet.Id a, PatchSet.Id b,
PatchScriptSettings settings, AsyncCallback<PatchScript> callback); PatchScriptSettings settings, AsyncCallback<PatchScript> callback);

3
gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java
View File

@ -21,11 +21,14 @@ import com.google.gerrit.reviewdb.Project;
import com.google.gerrit.reviewdb.ProjectRight; import com.google.gerrit.reviewdb.ProjectRight;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.VoidResult; import com.google.gwtjsonrpc.client.VoidResult;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
import java.util.List; import java.util.List;
import java.util.Set; import java.util.Set;
@RpcImpl(version = Version.V2_0)
public interface ProjectAdminService extends RemoteJsonService { public interface ProjectAdminService extends RemoteJsonService {
@SignInRequired @SignInRequired
void ownedProjects(AsyncCallback<List<Project>> callback); void ownedProjects(AsyncCallback<List<Project>> callback);

3
gerrit-common/src/main/java/com/google/gerrit/common/data/SuggestService.java
View File

@ -18,9 +18,12 @@ import com.google.gerrit.reviewdb.AccountGroup;
import com.google.gerrit.reviewdb.Project; import com.google.gerrit.reviewdb.Project;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
import java.util.List; import java.util.List;
@RpcImpl(version = Version.V2_0)
public interface SuggestService extends RemoteJsonService { public interface SuggestService extends RemoteJsonService {
void suggestProjectNameKey(String query, int limit, void suggestProjectNameKey(String query, int limit,
AsyncCallback<List<Project.NameKey>> callback); AsyncCallback<List<Project.NameKey>> callback);

3
gerrit-common/src/main/java/com/google/gerrit/common/data/SystemInfoService.java
View File

@ -19,9 +19,12 @@ import com.google.gerrit.reviewdb.ContributorAgreement;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.AllowCrossSiteRequest; import com.google.gwtjsonrpc.client.AllowCrossSiteRequest;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
import java.util.List; import java.util.List;
@RpcImpl(version = Version.V2_0)
public interface SystemInfoService extends RemoteJsonService { public interface SystemInfoService extends RemoteJsonService {
@AllowCrossSiteRequest @AllowCrossSiteRequest
void daemonHostKeys(AsyncCallback<List<SshHostKey>> callback); void daemonHostKeys(AsyncCallback<List<SshHostKey>> callback);

3
gerrit-gwtui/src/main/java/com/google/gerrit/client/HostPageDataService.java
View File

@ -18,7 +18,10 @@ import com.google.gerrit.common.data.HostPageData;
import com.google.gwt.user.client.rpc.AsyncCallback; import com.google.gwt.user.client.rpc.AsyncCallback;
import com.google.gwtjsonrpc.client.HostPageCache; import com.google.gwtjsonrpc.client.HostPageCache;
import com.google.gwtjsonrpc.client.RemoteJsonService; import com.google.gwtjsonrpc.client.RemoteJsonService;
import com.google.gwtjsonrpc.client.RpcImpl;
import com.google.gwtjsonrpc.client.RpcImpl.Version;
@RpcImpl(version = Version.V2_0)
interface HostPageDataService extends RemoteJsonService { interface HostPageDataService extends RemoteJsonService {
@HostPageCache(name = "gerrit_hostpagedata_obj", once = true) @HostPageCache(name = "gerrit_hostpagedata_obj", once = true)
void load(AsyncCallback<HostPageData> callback); void load(AsyncCallback<HostPageData> callback);