opendev/gerrit
Code Issues Proposed changes

Log OpenID SSL failures

Browse Source 
If the JRE is missing the root certificates, it can't connect to
the big OpenID providers like Yahoo! or Google.  Ensure the admin
gets a description of the SSL handshake errors in the server log,
so they can more quickly troubleshoot the problem.

Bug: issue 513
Change-Id: I55541db703d338214fa65bd1a66664d0a0aa5d02
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce 2010-03-26 12:52:11 -07:00
parent dcecffc660
commit a8653b45d8
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-httpd/src/main/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java
View File

@ -143,6 +143,7 @@ class OpenIdServiceImpl implements OpenIdService {
final List<?> list = manager.discover(url);
return list != null && !list.isEmpty() ? list : null;
} catch (DiscoveryException e) {
log.error("Cannot discover OpenID " + url, e);
return null;
}
}