From f9771e88ca433dfe0730ae9c0795b9f367004659 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Mon, 18 Mar 2019 15:03:46 -0700 Subject: [PATCH] Inspect all configs in manage-projects We were skipping the setting of retired project acls in manage-projects because we were iterating over projects that weren't retired. In manage-projects we don't want to skip over retired projects so that we can retire the projects properly. Address this by adding a new registry property that returns all projects retired or not then iterate over that in manage-projects. Change-Id: I7aa89b53696fb0fca262fc7068e5e2ad2b7ad8fc --- jeepyb/cmd/manage_projects.py | 2 +- jeepyb/utils.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/jeepyb/cmd/manage_projects.py b/jeepyb/cmd/manage_projects.py index 0a3cba2..27dde5e 100644 --- a/jeepyb/cmd/manage_projects.py +++ b/jeepyb/cmd/manage_projects.py @@ -474,7 +474,7 @@ def main(): try: # Collect processed errors,if any process_errors = [] - for section in registry.configs_list: + for section in registry.all_configs_list: project = section['project'] if args.projects and project not in args.projects: continue diff --git a/jeepyb/utils.py b/jeepyb/utils.py index 21ae550..f51d13c 100644 --- a/jeepyb/utils.py +++ b/jeepyb/utils.py @@ -237,3 +237,7 @@ class ProjectsRegistry(object): @property def configs_list(self): return [entry for entry in self._configs_list if not is_retired(entry)] + + @property + def all_configs_list(self): + return self._configs_list