opendev/puppet-zanata
Code Issues Proposed changes

Fix lint issues

Browse Source 
This fixes linter issues with parameter ordering. Required parameters
must come first.

Change-Id: I31f1cc51ade2ac95087af3b2cdc8843396c23c12
This commit is contained in:
Clark Boylan 2017-06-09 06:59:31 -07:00
parent b83241f180
commit 1a13f760ed
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
manifests/init.pp
View File

@ -16,11 +16,12 @@
# #
class zanata( class zanata(
$zanata_default_from_address,
$zanata_db_password,
$mysql_host = 'localhost', $mysql_host = 'localhost',
$mysql_port = '3306', $mysql_port = '3306',
$zanata_db_name = 'zanata', $zanata_db_name = 'zanata',
$zanata_db_username = 'zanata', $zanata_db_username = 'zanata',
$zanata_db_password,
# For wildfly < 10 the zanata_url below is expected to be a url to a built # For wildfly < 10 the zanata_url below is expected to be a url to a built
# war for wildfly >=10 the expectation is that it is the url to one of the # war for wildfly >=10 the expectation is that it is the url to one of the
@ -38,7 +39,6 @@ class zanata(
# This should be a sha1 of whatever file is hosted at the url above. # This should be a sha1 of whatever file is hosted at the url above.
$zanata_checksum = '59f1ac35cce46ba4e46b06a239cd7ab4e10b5528', $zanata_checksum = '59f1ac35cce46ba4e46b06a239cd7ab4e10b5528',
$zanata_default_from_address,
$zanata_storage_dir = '/home/wildfly/zanata', $zanata_storage_dir = '/home/wildfly/zanata',
$zanata_openid_provider_url = '', $zanata_openid_provider_url = '',
@ -52,7 +52,6 @@ class zanata(
$zanata_smtp_password = '', $zanata_smtp_password = '',
$zanata_smtp_tls = '', $zanata_smtp_tls = '',
$zanata_smtp_ssl = '', $zanata_smtp_ssl = '',
) { ) {
zanata::validate_listener { $zanata_listeners: } zanata::validate_listener { $zanata_listeners: }

3
manifests/mysql.pp
View File

@ -15,14 +15,13 @@
# == Class: zanata::mysql # == Class: zanata::mysql
# #
class zanata::mysql( class zanata::mysql(
$db_password,
$mysql_root_password = '', $mysql_root_password = '',
$mysql_host = 'localhost', $mysql_host = 'localhost',
$mysql_bind_address = '127.0.0.1', $mysql_bind_address = '127.0.0.1',
$mysql_port = '3306', $mysql_port = '3306',
$db_name = 'zanata', $db_name = 'zanata',
$db_username = 'zanata', $db_username = 'zanata',
$db_password,
) { ) {
class { '::mysql::server': class { '::mysql::server':