opendev/storyboard
Code Issues Proposed changes

Remove simple priority support from the API

Browse Source 
This commit removes the response "priority" from
the API, and also, removes the Unit Test the verified
this from ".tests/test_notification_hook.py".
The old priority data remains preserved in the database.

Change-Id: Idfb2f22675d932ff9c0371bc352b8d0115799cf5
Task: #3200
This commit is contained in:
Camila Moura 2019-03-14 10:35:07 +01:00
parent a2f0f207cd
commit 02561b86f3
2 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
storyboard/api/v1/wmodels.py
View File

@ -330,9 +330,6 @@ class Task(base.APIBase):
assignee_id = int
"""The ID of the invidiual to whom this task is assigned."""
priority = wtypes.text
"""The priority for this task, one of 'low', 'medium', 'high'"""
branch_id = int
"""The ID of corresponding Branch"""
@ -352,7 +349,6 @@ class Task(base.APIBase):
link="Some notes about the task, this name is bad.",
project_id=1,
assignee_id=1,
priority="medium",
branch_id=1,
milestone_id=1,
due_dates=[1, 2, 3])

4
storyboard/tests/notifications/test_notification_hook.py
View File

@ -173,8 +173,6 @@ class TestNotificationHook(base.BaseDbTestCase):
sample_task_wmodel.project_id)
self.assertEqual(old_entity_values['assignee_id'],
sample_task_wmodel.assignee_id)
self.assertEqual(old_entity_values['priority'],
sample_task_wmodel.priority)
@patch('storyboard.db.api.base.entity_get')
def test_old_entity_values_set_on_state_by_before(self, mock_entity_get):
@ -218,8 +216,6 @@ class TestNotificationHook(base.BaseDbTestCase):
sample_task_wmodel.project_id)
self.assertEqual(mock_state.old_entity_values['assignee_id'],
sample_task_wmodel.assignee_id)
self.assertEqual(mock_state.old_entity_values['priority'],
sample_task_wmodel.priority)
@patch('storyboard.notifications.notification_hook.publish')
@patch.object(NotificationHook, 'get_original_resource')