From 708f6f2177f84baa5bc70bf433a9ab21a8743bf7 Mon Sep 17 00:00:00 2001 From: Adam Coldrick Date: Tue, 8 Dec 2015 14:04:37 +0000 Subject: [PATCH] Don't delete subscription if sub_resource is set This patch stops subscriptions being erroneously deleted if a DELETE request is recieved with a path which has a sub_resource but no sub_resource_id. For example: DELETE /v1/stories/1/tags This fixes a bug whereby deleting a tag from a story unsubscribes everyone from that story. Change-Id: I2166ae63d940ec40e45a8bb7a97779099131f7cd --- storyboard/plugin/subscription/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storyboard/plugin/subscription/base.py b/storyboard/plugin/subscription/base.py index e7ddb109..c11932ba 100644 --- a/storyboard/plugin/subscription/base.py +++ b/storyboard/plugin/subscription/base.py @@ -63,7 +63,7 @@ class Subscription(WorkerTaskBase): author=author, subscribers=subscribers) - if method == 'DELETE' and not sub_resource_id: + if method == 'DELETE' and not (sub_resource_id or sub_resource): self.handle_deletions(session, resource, resource_id) def handle_deletions(self, session, resource_name, resource_id):