From 0293b260d9624e7a1be920b98984f9a58b8c219e Mon Sep 17 00:00:00 2001
From: Clark Boylan <clark.boylan@gmail.com>
Date: Tue, 12 Dec 2017 14:00:08 -0800
Subject: [PATCH] Reduce cacti updates cron spam

The current process to udpate cacti hosts is fairly chatty. It basically
goes in and just tries to update every host there and if they exist that
generates a bunch of output which is then emailed to infra roots. This
information is potentially useful for debugging so keep it around in
local cacti host logs. These logs will then be rotated with a week of
retention.

This should help make our inboxes happier.

Change-Id: Ib03ef7b22083a2a2454715bd5229313b19b84ae9
---
 modules/openstack_project/manifests/cacti.pp | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/modules/openstack_project/manifests/cacti.pp b/modules/openstack_project/manifests/cacti.pp
index 36f6c445a9..eb2665bab4 100644
--- a/modules/openstack_project/manifests/cacti.pp
+++ b/modules/openstack_project/manifests/cacti.pp
@@ -83,9 +83,21 @@ class openstack_project::cacti (
   cron { 'add cacti hosts':
     ensure  => present,
     user    => root,
-    command => 'for host in $(cat /var/lib/cacti/devices); do /usr/local/bin/create_graphs.sh $host; done',
+    command => 'for host in $(cat /var/lib/cacti/devices); do /usr/local/bin/create_graphs.sh $host >> /var/log/cacti_update.log 2>&1; done',
     minute  => '0',
   }
 
-
+  include logrotate
+  logrotate::file { 'cacti_update.log':
+    log     => '/var/log/cacti_update.log',
+    options => [
+      'compress',
+      'missingok',
+      'rotate 7',
+      'daily',
+      'notifempty',
+      'copytruncate',
+    ],
+    require => Cron['add cacti hosts'],
+  }
 }