Puppet lint fixes

Also move contents of /etc/bup-excludes into a file

Change-Id: I206c08d05114cdacb18d00e4a4578679398990ec
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/15841
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins

modules/bup/files/etc/bup-excludes

@@ -0,0 +1,12 @@
+/proc/*
+/sys/*
+/dev/*
+/tmp/*
+/floppy/*
+/cdrom/*
+/var/spool/squid/*
+/var/spool/exim/*
+/media/*
+/mnt/*
+/var/agentx/*
+/run/*

modules/bup/manifests/init.pp

@@ -1,23 +1,12 @@
+# Class: bup
+#
 class bup {
-  package { "bup":
+  package { 'bup':
-    ensure => present
-  }
-
-  file { "/etc/bup-excludes":
     ensure => present,
-    content => "/proc/*
-/sys/*
-/dev/*
-/tmp/*
-/floppy/*
-/cdrom/*
-/var/spool/squid/*
-/var/spool/exim/*
-/media/*
-/mnt/*
-/var/agentx/*
-/run/*
-"
   }
 
+  file { '/etc/bup-excludes':
+    ensure  => present,
+    content => 'puppet:///modules/bup/etc/bup-exculdes',
+  }
 }

modules/bup/manifests/site.pp

@@ -1,8 +1,13 @@
-define bup::site($backup_user, $backup_server) {
+# Define: bup::site
-  cron { "bup-$name":
+#
-    user => root,
+define bup::site(
-    hour => "5",
+  $backup_user,
-    minute => "37",
+  $backup_server
-    command => "tar -X /etc/bup-excludes -cPf - / | bup split -r $backup_user@$backup_server: -n root -q",
+) {
+  cron { "bup-${name}":
+    user    => 'root',
+    hour    => '5',
+    minute  => '37',
+    command => "tar -X /etc/bup-excludes -cPf - / | bup split -r ${backup_user}@${backup_server}: -n root -q",
   }
 }