opendev/system-config
Code Issues Proposed changes

Move hardcoded values into jenkins class params

Browse Source 
Move serveradmin and logo to openstack_project::jenkins
class and keep hardcoded values as default values.

Change-Id: Ifb3ee06c927b175340e53a1ffad116a21f303075
This commit is contained in:
Fabien Boucher 2015-03-24 15:58:10 +00:00
parent a67935690b
commit 0a7f6331b9
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/openstack_project/manifests/jenkins.pp
View File

@ -18,6 +18,8 @@ class openstack_project::jenkins (
$zmq_event_receivers = [], $zmq_event_receivers = [],
$sysadmins = [], $sysadmins = [],
$project_config_repo = '', $project_config_repo = '',
$serveradmin = 'webmaster@openstack.org',
$logo = 'openstack.png',
) inherits openstack_project { ) inherits openstack_project {
include openstack_project include openstack_project
@ -46,8 +48,8 @@ class openstack_project::jenkins (
class { '::jenkins::master': class { '::jenkins::master':
vhost_name => $vhost_name, vhost_name => $vhost_name,
serveradmin => 'webmaster@openstack.org', serveradmin => $serveradmin,
logo => 'openstack.png', logo => $logo,
ssl_cert_file => $prv_ssl_cert_file, ssl_cert_file => $prv_ssl_cert_file,
ssl_key_file => $prv_ssl_key_file, ssl_key_file => $prv_ssl_key_file,
ssl_chain_file => $ssl_chain_file, ssl_chain_file => $ssl_chain_file,