opendev/system-config
Code Issues Proposed changes

Improve zuul status page efficiency.

Browse Source 
Don't poll server when page isn't visible.
Install and use the jquery-visibility plugin.

Change-Id: I377f2ebe2385668a93d46d31ddf2ec5744f8d26b
Reviewed-on: https://review.openstack.org/18606
Approved: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
This commit is contained in:
James E. Blair 2012-12-23 10:37:26 -08:00 committed by Jenkins
parent 8eb46312cb
commit 0b2cba4e99
3 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/openstack_project/files/zuul/status.html
View File

@ -43,6 +43,7 @@
<TITLE>Zuul Status</TITLE> <TITLE>Zuul Status</TITLE>
<script type="text/javascript" src="jquery.min.js"></script> <script type="text/javascript" src="jquery.min.js"></script>
<script type="text/javascript" src="jquery-visibility.min.js"></script>
<script type="text/javascript" src="status.js"></script> <script type="text/javascript" src="status.js"></script>

17
modules/openstack_project/files/zuul/status.js
View File

@ -12,6 +12,8 @@
// License for the specific language governing permissions and limitations // License for the specific language governing permissions and limitations
// under the License. // under the License.
window.zuul_enable_status_updates = true;
function format_pipeline(data) { function format_pipeline(data) {
var html = '<div class="pipeline"><h3 class="subhead">'+ var html = '<div class="pipeline"><h3 class="subhead">'+
data['name']+'</h3>'; data['name']+'</h3>';
@ -90,6 +92,11 @@ function format_change(change) {
function update() { function update() {
var html = ''; var html = '';
if (!window.zuul_enable_status_updates) {
setTimeout(update, 5000);
return;
}
$.getJSON('http://zuul.openstack.org/status.json', function(data) { $.getJSON('http://zuul.openstack.org/status.json', function(data) {
if ('message' in data) { if ('message' in data) {
$("#message-container").attr('class', 'topMessage'); $("#message-container").attr('class', 'topMessage');
@ -113,4 +120,14 @@ function update() {
$(function() { $(function() {
update(); update();
$(document).on({
'show.visibility': function() {
window.zuul_enable_status_updates = true;
},
'hide.visibility': function() {
window.zuul_enable_status_updates = false;
}
});
}); });

16
modules/openstack_project/manifests/zuul.pp
View File

@ -80,7 +80,8 @@ class openstack_project::zuul(
file { '/var/lib/zuul/www/jquery.min.js': file { '/var/lib/zuul/www/jquery.min.js':
ensure => link, ensure => link,
target => '/usr/share/javascript/jquery/jquery.min.js', target => '/usr/share/javascript/jquery/jquery.min.js',
require => Package['libjs-jquery'], require => [File['/var/lib/zuul/www'],
Package['libjs-jquery']],
} }
file { '/var/lib/zuul/www/status.js': file { '/var/lib/zuul/www/status.js':
@ -88,4 +89,17 @@ class openstack_project::zuul(
source => 'puppet:///modules/openstack_project/zuul/status.js', source => 'puppet:///modules/openstack_project/zuul/status.js',
require => File['/var/lib/zuul/www'], require => File['/var/lib/zuul/www'],
} }
vcsrepo { '/opt/jquery-visibility':
ensure => latest,
provider => git,
revision => 'master',
source => 'https://github.com/mathiasbynens/jquery-visibility.git',
}
file { '/var/lib/zuul/www/jquery-visibility.min.js':
ensure => link,
target => '/opt/jquery-visibility/jquery-visibility.min.js',
require => File['/var/lib/zuul/www'],
}
} }