From 7c9d9d79932cdc9fa86f50b5b1289b07895dbe22 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Thu, 24 Feb 2022 14:41:17 -0800 Subject: [PATCH] Remove Gerrit's JVM GC logs These were added when we faced significant memory pressure on the old server. That is no longer a problem and there is an issue with the specification that breaks file compression due to destination files already existing. It seems like the log specification is only able to rotate once then it cannot keep moving files aside because they already exist as eg jvm_gc.log.0.gz. This results in annoying errors in the Gerrit error_log. Note that it doesn't appear sufficient to remove this log specification we also need to move the existing jvm_gc.log* files aside or delete them. This was tested on a held zuul node and I stopped gerrit, updated the docker-compose file, moved the files aside, then started gerrit and that got rid of the startup errors in error_log. Merely updating docker-compose resulted in the same errors on startup. Change-Id: Ied1464c57b2e8331b9bdf7cbc9ad74f92dea2dfd --- playbooks/roles/gerrit/templates/docker-compose.yaml.j2 | 1 - 1 file changed, 1 deletion(-) diff --git a/playbooks/roles/gerrit/templates/docker-compose.yaml.j2 b/playbooks/roles/gerrit/templates/docker-compose.yaml.j2 index 4f370e4f29..4626a2db6f 100644 --- a/playbooks/roles/gerrit/templates/docker-compose.yaml.j2 +++ b/playbooks/roles/gerrit/templates/docker-compose.yaml.j2 @@ -32,7 +32,6 @@ services: {% endfor %} environment: JAVA_OPTIONS: >- - -Xlog:gc*:file=/var/gerrit/logs/jvm_gc.log:time,uptime,tid,level,tags:filecount=10,filesize=20M -Dlog4j2.formatMsgNoLookups=true {% if gerrit_heap_limit is defined %} -Xmx{{ gerrit_heap_limit }}