From 22532c53f6594b25f203116f64d8181540e24f25 Mon Sep 17 00:00:00 2001
From: Andrew Hutchings <andrew@linuxjedi.co.uk>
Date: Wed, 2 May 2012 16:38:02 +0100
Subject: [PATCH] Add plain gerrit trigger comment

Use this on all non-merge jobs

Fixes bug #988584

Change-Id: Ia9bfecc872b63fd53da0be6f6063b3db66dfeac2
---
 .../jenkins_jobs/manifests/jobs/merge_gate.pp |  2 +-
 .../jenkins_jobs/manifests/jobs/pep8_gate.pp  |  2 +-
 .../manifests/jobs/python26_gate.pp           |  2 +-
 .../manifests/jobs/python27_gate.pp           |  2 +-
 ...b => trigger_gerrit_comment_merge.xml.erb} |  0
 .../trigger_gerrit_comment_plain.xml.erb      | 30 +++++++++++++++++++
 6 files changed, 34 insertions(+), 4 deletions(-)
 rename modules/jenkins_jobs/templates/{trigger_gerrit_comment.xml.erb => trigger_gerrit_comment_merge.xml.erb} (100%)
 create mode 100644 modules/jenkins_jobs/templates/trigger_gerrit_comment_plain.xml.erb

diff --git a/modules/jenkins_jobs/manifests/jobs/merge_gate.pp b/modules/jenkins_jobs/manifests/jobs/merge_gate.pp
index 1e195350e2..72356d01e6 100644
--- a/modules/jenkins_jobs/manifests/jobs/merge_gate.pp
+++ b/modules/jenkins_jobs/manifests/jobs/merge_gate.pp
@@ -5,7 +5,7 @@ define jenkins_jobs::jobs::merge_gate($site, $project, $node_group, $trigger_bra
     project => $project,
     job => "merge",
     node_group => $node_group,
-    triggers => trigger("gerrit_comment"),
+    triggers => trigger("gerrit_comment_merge"),
     builders => builder("gerrit_git_prep"),
     trigger_branches => $trigger_branches,
     auth_build => true
diff --git a/modules/jenkins_jobs/manifests/jobs/pep8_gate.pp b/modules/jenkins_jobs/manifests/jobs/pep8_gate.pp
index fcfba45757..ffd3bf7d72 100644
--- a/modules/jenkins_jobs/manifests/jobs/pep8_gate.pp
+++ b/modules/jenkins_jobs/manifests/jobs/pep8_gate.pp
@@ -5,7 +5,7 @@ define jenkins_jobs::jobs::pep8_gate($site, $project, $node_group, $trigger_bran
     project => $project,
     job => "pep8",
     node_group => $node_group,
-    triggers => trigger("gerrit_comment"),
+    triggers => trigger("gerrit_comment_plain"),
     builders => [builder("gerrit_git_prep"), builder("copy_bundle"), builder("pep8")],
     publishers => publisher("pep8"),
     trigger_branches => $trigger_branches,
diff --git a/modules/jenkins_jobs/manifests/jobs/python26_gate.pp b/modules/jenkins_jobs/manifests/jobs/python26_gate.pp
index 7a3dedae1b..fa4f0de3e3 100644
--- a/modules/jenkins_jobs/manifests/jobs/python26_gate.pp
+++ b/modules/jenkins_jobs/manifests/jobs/python26_gate.pp
@@ -5,7 +5,7 @@ define jenkins_jobs::jobs::python26_gate($site, $project, $node_group, $trigger_
     project => $project,
     job => "python26",
     node_group => $node_group,
-    triggers => trigger("gerrit_comment"),
+    triggers => trigger("gerrit_comment_plain"),
     builders => [builder("gerrit_git_prep"), builder("copy_bundle"), builder("python26")],
     trigger_branches => $trigger_branches,
     auth_build => true
diff --git a/modules/jenkins_jobs/manifests/jobs/python27_gate.pp b/modules/jenkins_jobs/manifests/jobs/python27_gate.pp
index 16c32727ef..0e519700ea 100644
--- a/modules/jenkins_jobs/manifests/jobs/python27_gate.pp
+++ b/modules/jenkins_jobs/manifests/jobs/python27_gate.pp
@@ -5,7 +5,7 @@ define jenkins_jobs::jobs::python27_gate($site, $project, $node_group, $trigger_
     project => $project,
     job => "python27",
     node_group => $node_group,
-    triggers => trigger("gerrit_comment"),
+    triggers => trigger("gerrit_comment_plain"),
     builders => [builder("gerrit_git_prep"), builder("copy_bundle"), builder("python27")],
     trigger_branches => $trigger_branches,
     auth_build => true
diff --git a/modules/jenkins_jobs/templates/trigger_gerrit_comment.xml.erb b/modules/jenkins_jobs/templates/trigger_gerrit_comment_merge.xml.erb
similarity index 100%
rename from modules/jenkins_jobs/templates/trigger_gerrit_comment.xml.erb
rename to modules/jenkins_jobs/templates/trigger_gerrit_comment_merge.xml.erb
diff --git a/modules/jenkins_jobs/templates/trigger_gerrit_comment_plain.xml.erb b/modules/jenkins_jobs/templates/trigger_gerrit_comment_plain.xml.erb
new file mode 100644
index 0000000000..b30c2ccdc2
--- /dev/null
+++ b/modules/jenkins_jobs/templates/trigger_gerrit_comment_plain.xml.erb
@@ -0,0 +1,30 @@
+    <com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger>
+      <spec></spec>
+      <gerritProjects>
+        <% trigger_branches.each do |trigger| %>
+        <com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject>
+          <compareType>PLAIN</compareType>
+          <pattern><%= site %>/<%= trigger[0] %></pattern>
+          <branches>
+            <com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.Branch>
+              <compareType>ANT</compareType>
+              <pattern><%= trigger[1] %></pattern>
+            </com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.Branch>
+          </branches>
+        </com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject>
+        <% end %>
+      </gerritProjects>
+      <silentMode>false</silentMode>
+      <escapeQuotes>true</escapeQuotes>
+      <triggerOnPatchsetUploadedEvent>false</triggerOnPatchsetUploadedEvent>
+      <triggerOnChangeMergedEvent>false</triggerOnChangeMergedEvent>
+      <triggerOnCommentAddedEvent>true</triggerOnCommentAddedEvent>
+      <triggerOnRefUpdatedEvent>false</triggerOnRefUpdatedEvent>
+      <commentAddedTriggerApprovalCategory>APRV</commentAddedTriggerApprovalCategory>
+      <commentAddedTriggerApprovalValue>1</commentAddedTriggerApprovalValue>
+      <buildStartMessage></buildStartMessage>
+      <buildFailureMessage></buildFailureMessage>
+      <buildSuccessfulMessage></buildSuccessfulMessage>
+      <buildUnstableMessage></buildUnstableMessage>
+      <customUrl></customUrl>
+    </com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger>