From 275fcba2e57e1093bda3fea8f6ead9413666d283 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Mon, 25 Apr 2022 11:03:50 -0700 Subject: [PATCH] Explicitly disable Gerrit tracing.performanceLogging According to the docs [0] this shouldn't be necessary as performance logging only happens if a performance tracing plugin is installed. However according to this repo discuss thread [1] there is always a dummy performanceLogging instance installed. This same thread identifies this as a likely source for large increase in memory utilization by Gerrit when upgrading to 3.5. Let's explicitly disable this tracing due to the memory overhead in prep for our 3.5 upgrade. We can always flip the setting if we install a performance tracing plugin in our Gerrit. [0] https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#tracing [1] https://groups.google.com/g/repo-discuss/c/QUD7_LsEVks/m/kBDEeam4AgAJ Change-Id: Iff438695aa6488fb5886120121946494b1edf003 --- playbooks/roles/gerrit/templates/gerrit.config.j2 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/playbooks/roles/gerrit/templates/gerrit.config.j2 b/playbooks/roles/gerrit/templates/gerrit.config.j2 index ea2d955121..2ab3f2a626 100644 --- a/playbooks/roles/gerrit/templates/gerrit.config.j2 +++ b/playbooks/roles/gerrit/templates/gerrit.config.j2 @@ -56,6 +56,8 @@ maxThreads = 100 maxQueued = 200 requestLog = true +[tracing] + performanceLogging = false [cache] directory = cache [cache "accounts"]