opendev/system-config
Code Issues Proposed changes

Disable change.move and enableSignedPush in gerrit

Browse Source 
change.move is a new option in gerrit 3.0 that toggles whether or not
the change move api is enabled. We disable it because there are
potential confusing side effect for moving a change with parent changes
then merging the moved change. Details can be found in
https://bugs.chromium.org/p/gerrit/issues/detail?id=9877

We've not needed to move chagnes previously and users can abandon and
push to a different branch instead.

With enableSignedPush we set that to false even though it is an existing
default because newer gerrit seems to write it out to its config file.
We write it out to avoid unnecessary file updates after the upgrade.

Note I believe it is safe to land this on 2.13 or 2.16 as gerrit should
just ignore change.move until we get to 3.x and enableSignedPush already
defaults to false.

Change-Id: I9db2026b1e5cafefd448f33f74d6b7b60efafdb4
This commit is contained in:
Clark Boylan 2020-10-09 09:48:24 -07:00
parent cae58690dc
commit 2a85185bbc
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
playbooks/roles/gerrit/templates/gerrit.config
View File

@ -69,8 +69,10 @@
email = review@openstack.org
[change]
allowDrafts = false
move = false
[receive]
maxObjectSizeLimit = 100 m
enableSignedPush = false
[commentlink "bugheader"]
match = "([Cc]loses|[Pp]artial|[Rr]elated)-[Bb]ug:\\s*#?(\\d+)"
link = "https://launchpad.net/bugs/$2"