From 34ee1a56d9da52d52240dc8e54a69e8cb6df1c11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rados=C5=82aw=20Piliszek?= Date: Thu, 28 Jan 2021 20:27:19 +0100 Subject: [PATCH] ask.o.o: Fix two issues with ro message 1) The string is interpolated into JavaScript string which is delimited using double quotation marks - using double quotation marks in it breaks JavaScript parsing. The impact is unknown but at least some JavaScript code does not get executed later. 2) The anchor was unproperly closed causing void anchor to appear. This is clearly visible on the rendered page. Change-Id: I90cdcdd81c6af67f940c1811b1b9c05f9309ba15 --- modules/openstack_project/templates/askbot/settings.py.erb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/openstack_project/templates/askbot/settings.py.erb b/modules/openstack_project/templates/askbot/settings.py.erb index 0fbdc2469b..d09822e6d6 100644 --- a/modules/openstack_project/templates/askbot/settings.py.erb +++ b/modules/openstack_project/templates/askbot/settings.py.erb @@ -369,9 +369,9 @@ LIVESETTINGS_OPTIONS = { 'READ_ONLY_MODE_ENABLED': True, 'READ_ONLY_MESSAGE': 'The ask.openstack.org website will be read-only from ' - 'now on. Please ask questions on the openstack-discuss ' - 'mailing-list, stackoverflow.com for coding or ' - 'serverfault.com for operations.' + 'now on. Please ask questions on the openstack-discuss ' + 'mailing-list, stackoverflow.com for coding or ' + 'serverfault.com for operations.' }, 'GENERAL_SKIN_SETTINGS': { <% if @custom_theme_enabled %>