From 91f8760b3f48f5246f91d602885173b8bbe07c1d Mon Sep 17 00:00:00 2001 From: Khai Do Date: Wed, 14 Oct 2015 21:22:50 -0700 Subject: [PATCH] Fix toggle ci button for CS2 on Gerrit 2.11 Gerrit 2.11 UI changed the divs for the comment info section. The current use of innerHTML causes a TypeError[1] on page load because the object is undefined. This change works for both ver 2.8 and ver 2.11 [1] Uncaught TypeError: Cannot read property 'innerHTML' of undefined Change-Id: Id6871f3b28218bbd0feff8640512566dd57ca150 --- modules/openstack_project/files/gerrit/hideci.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/openstack_project/files/gerrit/hideci.js b/modules/openstack_project/files/gerrit/hideci.js index 51ddc39679..db2f4780f4 100644 --- a/modules/openstack_project/files/gerrit/hideci.js +++ b/modules/openstack_project/files/gerrit/hideci.js @@ -185,7 +185,7 @@ var ci_parse_comments = function() { var name = top.attr("name"); if (!name) { // new change screen - name = $(this).parent().prev().children()[0].innerHTML; + name = $(this).parent().parent().parent().children().children()[0].innerHTML } var comment = {}; comment.name = name; @@ -196,7 +196,7 @@ var ci_parse_comments = function() { comment.date = date_cell.attr("title"); } else { // new change screen - comment.date = $(this).parent().prev().children()[2].innerHTML; + comment.date = $(this).parent().parent().parent().children().children()[2].innerHTML } var comment_panel = $(this).parent(); comment.psnum = psnum;