opendev/system-config
Code Issues Proposed changes

Zuul status: don't toggle on link click

Browse Source 
Don't toggle the display of detailed info for a change if the user
clicks on the hyperlink within the header div.

Change-Id: I3f20dfe6a4ee40b79859572017721a45acbc5672
This commit is contained in:
James E. Blair 2014-01-02 11:41:14 -08:00 committed by Sean Dague
parent cb4a84366c
commit 41d28dddbc
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
modules/openstack_project/files/zuul/status.js
View File

@ -230,7 +230,7 @@ function format_change(change, change_queue) {
html += '<td class="change-container">';
html += '<div class="change" id="' + safe_id(change['id']) + '">' +
'<div class="header" onClick="toggle_display_jobs(this)" ' +
'<div class="header" onClick="toggle_display_jobs(event, this)" ' +
'onmouseover="$(this).addClass(\'hover\')" ' +
'onmouseout="$(this).removeClass(\'hover\')">';
@ -310,8 +310,15 @@ function format_change(change, change_queue) {
return html;
}
function toggle_display_jobs(_header) {
function toggle_display_jobs(e, _header) {
e = e || window.event; // standards compliant || IE
var header = $(_header);
var target = $(e.target || e.srcElement);
var link = header.find("a");
if (target.is(link)) {
return true;
}
content = header.next("div");
content.slideToggle(100, function () {
changeid = header.parent().attr('id');