opendev/system-config
Code Issues Proposed changes

Use pip install -r not -f to install extras

Browse Source 
The pip install -f flag is for find-links which is a list of locations
to look for python packages. What we hvae at this path for extras
installation is a list of packages themselves not locations to find
them. We need to use the -r flag for requirements lists to specify this
instead.

This change should update our zuul and nodepool images to include useful
debugging extras.

Change-Id: I647bb835d0c85c3772e1593866a54cfc5ea1db2f
This commit is contained in:
Clark Boylan 2020-08-03 10:26:30 -07:00
parent 872663a270
commit 45da85124f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docker/python-builder/scripts/install-from-bindep
View File

@ -35,7 +35,7 @@ fi
# Add any requested extras to the list of things to install
EXTRAS=""
for extra in $* ; do
EXTRAS="${EXTRAS} -f /output/$extra/requirements.txt"
EXTRAS="${EXTRAS} -r /output/$extra/requirements.txt"
done
if [ -f /output/packages.txt ] ; then