From 64957e9e0d8ac5ff31068781f59bbcf1001932cb Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Thu, 9 Mar 2023 08:33:22 -0800 Subject: [PATCH] Fix boolean operator in submittableIf rules Gerrit 3.6 and older do not support 'and' as a boolean operator. They only support 'AND'. For maximum compatibility (we are running 3.6.4 currently) convert 'and' to 'AND' in Gerrit submittableIf rules. Change-Id: Iac5e2cda4a245f99e98a1354ad4107da07e1f60d --- doc/source/gerrit.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/source/gerrit.rst b/doc/source/gerrit.rst index df730c33b5..2574a7b04b 100644 --- a/doc/source/gerrit.rst +++ b/doc/source/gerrit.rst @@ -304,7 +304,7 @@ Next, edit ``project.config`` to look like:: [submit-requirement "Code-Review"] description = Code reviewed - submittableIf = label:Code-Review=MAX and -label:Code-Review=MIN + submittableIf = label:Code-Review=MAX AND -label:Code-Review=MIN canOverrideInChildProjects = true [label "Verified"] @@ -317,7 +317,7 @@ Next, edit ``project.config`` to look like:: [submit-requirement "Verified"] description = Code verified by Zuul - submittableIf = label:Verified=MAX and -label:Verified=MIN + submittableIf = label:Verified=MAX AND -label:Verified=MIN [label "Workflow"] function = NoBlock @@ -327,7 +327,7 @@ Next, edit ``project.config`` to look like:: [submit-requirement "Workflow"] description = Approved by core member - submittableIf = label:Workflow=MAX and -label:Workflow=MIN + submittableIf = label:Workflow=MAX AND -label:Workflow=MIN [plugin "its-storyboard"] enabled = true