opendev/system-config
Code Issues Proposed changes

Avoid generated-groups when creating generated-groups

Browse Source 
As explained in the comment, with the generated-groups file in the
inventory, as we regenerate the groups we end up finding old entries
that have actually disappeared and keep putting them back in.

Change-Id: I86463ecf516c38bb08d3d45e706a0da61a33efdf
This commit is contained in:
Ian Wienand 2017-12-20 10:29:32 +11:00
parent bd56a81619
commit 6fff5a4bad
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
modules/openstack_project/files/puppetmaster/expand-groups.sh
View File

@ -24,12 +24,24 @@ echo "# This file is autogenerated" > $outfile
unset OS_CLOUD
unset OS_REGION_NAME
# Because we are generating "generated-groups", we need to work on an
# inventory without out it ... otherwise entries that have actually
# disappeared (according to /etc/ansible/hosts/openstack's live list)
# will keep coming back as "ansible --list" finds them in the
# generated-groups file. Later versions of ansible have a
# "inventory_ignore_patterns" that might help, we just copy & remove
# in a separate inventory
inv=${outdir}/hosts
mkdir ${inv}
cp /etc/ansible/hosts/* ${inv}
rm -f ${inv}/generated-groups*
IFS=$'\n'
for line in $(</etc/ansible/groups.txt); do
name=$(echo $line | cut -f1 -d' ')
pattern=$(echo $line | cut -f2 -d' ')
echo "[${name}]" >> $outfile
ansible "${pattern}" --list-hosts | egrep -v '^ +hosts \([0-9]+\):' >> $outfile
ansible -i ${inv} "${pattern}" --list-hosts | egrep -v '^ +hosts \([0-9]+\):' >> $outfile
done
cp $outfile /etc/ansible/hosts/generated-groups