opendev/system-config
Code Issues Proposed changes

Force case sensitive Gerrit users in config

Browse Source 
The default for existing Gerrit installations is that usernames remain
case sensitive when upgrading to 3.5. However new 3.5 installations will
be case insensitive by default. Since we have a long history of
usernames where switching to insensitive is not possible we force
usernames to be sensitive regardless of whether or not this is a new
install or an existing one.

A major reason for this is it means our system-config-run-review-3.5
jobs which install a new Gerrit 3.5 installation will match the
production behavior which will be upgraded from 3.4. Without this we may
get disparate behavior.

Note Gerrit 3.4 should ignore the setting and it should be safe to set
this on 3.4 as well as 3.5.

Change-Id: Ie4880bf580496a763cf042570bf8b9ff852ffb0e
This commit is contained in:
Clark Boylan 2022-02-03 15:01:18 -08:00
parent 0197aa43e1
commit 7097c3736b
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
playbooks/roles/gerrit/templates/gerrit.config.j2
View File

@ -8,15 +8,17 @@
reportBugUrl = "https://docs.openstack.org/infra/system-config/project.html#contributing"
gitHttpUrl = https://{{ gerrit_vhost_name }}/
serverId = {{ gerrit_serverid }}
{% if not gerrit_run_init_dev_mode %}
[auth]
# We have a long history of case sensitive usernames and need
# to preserve that behavior.
userNameCaseInsensitive = false
{% if not gerrit_run_init_dev_mode %}
contributorAgreements = true
type = OPENID_SSO
cookieSecure = true
enableRunAs = true
openIdSsoUrl = https://login.ubuntu.com/+openid
{% else %}
[auth]
type = DEVELOPMENT_BECOME_ANY_ACCOUNT
# In dev mode it's very useful to be able to reload plugins
[plugins]