opendev/system-config
Code Issues Proposed changes

Be explicit about node_prepare.sh args.

Browse Source 
If $HOSTNAME is not set when calling prepare_node.sh then SUDO value
could be confused for the hostname. Quote $HOSTNAME so it is clear which
arg belongs to each arg position in prepare_node.sh.

Change-Id: I9efffa5225de618b57980c1d60da24d7904cd91b
This commit is contained in:
Clark Boylan 2014-02-05 17:17:13 -08:00
parent dc13aa372f
commit 74db309b78
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/openstack_project/files/nodepool/scripts/prepare_node_bare.sh
View File

@ -18,4 +18,4 @@
HOSTNAME=$1
./prepare_node.sh $HOSTNAME false
./prepare_node.sh "$HOSTNAME" false

2
modules/openstack_project/files/nodepool/scripts/prepare_node_devstack.sh
View File

@ -18,5 +18,5 @@
HOSTNAME=$1
./prepare_node.sh $HOSTNAME true
./prepare_node.sh "$HOSTNAME" true
sudo -u jenkins -i /opt/nodepool-scripts/prepare_devstack.sh $HOSTNAME

2
modules/openstack_project/files/nodepool/scripts/prepare_node_devstack_new_kernel.sh
View File

@ -18,5 +18,5 @@
HOSTNAME=$1
./prepare_node.sh $HOSTNAME
./prepare_node.sh "$HOSTNAME" true
sudo -u jenkins -i /opt/nodepool-scripts/prepare_devstack_new_kernel.sh $HOSTNAME

2
modules/openstack_project/files/nodepool/scripts/prepare_node_tripleo.sh
View File

@ -20,5 +20,5 @@ HOSTNAME=$1
# Workaround bug 1270646 during node bootstrapping.
sudo ip link set mtu 1458 dev eth0
./prepare_node.sh $HOSTNAME true
./prepare_node.sh "$HOSTNAME" true
sudo -u jenkins -i /opt/nodepool-scripts/prepare_tripleo.sh $HOSTNAME