From 7551e1cfa1e20a2bea77cec1fd98a17d75e38f3d Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Tue, 9 Dec 2014 09:50:30 -0800 Subject: [PATCH] Make localuser gid and uid required params Before we had set gid and uid to unset by default. Which if not overridden will have puppet try to set the gid and uid values to 'unset'. This should be an error as 'unset' is not a number. We don't have this error because we always override these values when creating localusers. But for completeness and better error messages remove the default values so that puppet requires users to have proper gid and uid values. Change-Id: I14667912b9239ea1c56123c18b0c13834f9c3cb6 --- modules/user/manifests/virtual/localuser.pp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/user/manifests/virtual/localuser.pp b/modules/user/manifests/virtual/localuser.pp index 4f8112666d..4822d07681 100644 --- a/modules/user/manifests/virtual/localuser.pp +++ b/modules/user/manifests/virtual/localuser.pp @@ -4,14 +4,14 @@ define user::virtual::localuser( $realname, + $uid, + $gid, $groups = [ 'sudo', 'admin', ], $sshkeys = '', $key_id = '', $old_keys = [], $shell = '/bin/bash', $home = "/home/${title}", - $uid = unset, - $gid = unset, $managehome = true ) {