From b37ec6632a02da55f5fc636f4f4a48e472cf968f Mon Sep 17 00:00:00 2001 From: Ian Wienand Date: Fri, 3 Mar 2023 11:08:22 +1100 Subject: [PATCH] doc/gerrit : update to submit-requirements Update the MaxWithBlock function in the default labels to a new-format submit-requirement. Change-Id: I9887c4949fe375db0397bf273820e57a9d539749 --- doc/source/gerrit.rst | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/doc/source/gerrit.rst b/doc/source/gerrit.rst index 75cf085ffc..df730c33b5 100644 --- a/doc/source/gerrit.rst +++ b/doc/source/gerrit.rst @@ -295,27 +295,40 @@ Next, edit ``project.config`` to look like:: [label "Code-Review"] abbreviation = R copyCondition = changekind:TRIVIAL_REBASE OR is:MIN - function = MaxWithBlock + function = NoBlock value = -2 Do not merge value = -1 This patch needs further work before it can be merged value = 0 No score value = +1 Looks good to me, but someone else must approve value = +2 Looks good to me (core reviewer) + [submit-requirement "Code-Review"] + description = Code reviewed + submittableIf = label:Code-Review=MAX and -label:Code-Review=MIN + canOverrideInChildProjects = true + [label "Verified"] - function = MaxWithBlock + function = NoBlock value = -2 Fails value = -1 Doesn't seem to work value = 0 No score value = +1 Works for me value = +2 Verified + [submit-requirement "Verified"] + description = Code verified by Zuul + submittableIf = label:Verified=MAX and -label:Verified=MIN + [label "Workflow"] - function = MaxWithBlock + function = NoBlock value = -1 Work in progress value = 0 Ready for reviews value = +1 Approved + [submit-requirement "Workflow"] + description = Approved by core member + submittableIf = label:Workflow=MAX and -label:Workflow=MIN + [plugin "its-storyboard"] enabled = true