Merge "openafs-client: cleanup PPA install"

roles/openafs-client/tasks/openafs-client/Debian.yaml

@@ -1,19 +1,21 @@
-# Bionic and Focal versions both shipped unstable ~pre versions of
-# openafs clients; we thus have stable versions in a PPA.  We use this
-# everywhere but our legacy Xenial x86 hosts (Debian stable has 1.8
-# inbuilt so we are good there).
-# https://bugs.launchpad.net/ubuntu/+source/openafs/+bug/1832690
+# OpenAFS distro packages have been a little inconsistent; for example
+# Buster and Focal both shipped 1.8 "-pre" versions that upstream did
+# not consdier ready for release.  There have been occasional bugs we
+# need fixed in production, and other things we've needed pulled in
+# like ARM64 support.  So that's why we maintain our own packages
+# here.
 - name: Install openstackci openafs PPA on Ubuntu
   apt_repository:
     repo: 'ppa:openstack-ci-core/openafs'
   when:
-    - ansible_distribution == 'Ubuntu' and not
-      ( ansible_distribution_version is version('16.04', '==') and
-        ansible_architecture == 'x86_64' )
+    - ansible_distribution == 'Ubuntu'
   become: yes
 
-# We install the ppa on debian too in order to get the fixed pacakages
-# in our PPA
+# 2021-01-20 : for now we install the ppa on debian too in order to
+# get the 1.8.6-5 era packages that fixed a timestamp rollover issue
+# (see 1.8.7 release notes).  This can likely be removed if backports
+# make it to stable; see
+# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980115
 - name: Install openstackci openafs PPA on Debian
   apt_repository:
     repo: 'ppa:openstack-ci-core/openafs'