opendev/system-config
Code Issues Proposed changes

Push src and tx files to transifex separately.

Browse Source 
Push the source (.pot) file independently of the translation (.po) files
so that we can disable set -e when pushing the .po files.

Previously pushing the .po files would fail the entire test if one of
the pushed files contained no translations. This would also prevent
other translation files from being pushed. Now push the .pot file
separately so that a failure pushing that file still fails the test, but
errors pushing the translation files can be ignored. Also add the --skip
option to the translation push which will allow all valid translations
to be pushed even if some fail.

Change-Id: I8958c29113ce5d21a0b281ee13abe94d477fb04c
Reviewed-on: https://review.openstack.org/13385
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
This commit is contained in:
Clark Boylan 2012-09-20 10:21:31 -07:00 committed by Jenkins
parent ad56ee88c2
commit 7d018cc4b4
2 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
modules/jenkins/files/slave_scripts/propose_translation_update.sh
View File

@ -48,6 +48,13 @@ $COMMIT_MSG
EOF EOF
git review -t transifex/translations git review -t transifex/translations
# Push changes to transifex # Push .pot changes to transifex
tx --debug --traceback push -st tx --debug --traceback push -s
# Push translation changes to transifex
# Disable -e as we can live with failed translation pushes (failures
# occur when a translation file has no translations in it not really
# error worthy but they occur)
set +e
tx --debug --traceback push -t --skip
set -e
fi fi

11
modules/jenkins/files/slave_scripts/upstream_translation_update.sh
View File

@ -25,6 +25,13 @@ git add $PROJECT/locale/*
if [ ! `git diff-index --quiet HEAD --` ] if [ ! `git diff-index --quiet HEAD --` ]
then then
# Push changes to transifex # Push .pot changes to transifex
tx --debug --traceback push -st tx --debug --traceback push -s
# Push translation changes to transifex
# Disable -e as we can live with failed translation pushes (failures
# occur when a translation file has no translations in it not really
# error worthy but they occur)
set +e
tx --debug --traceback push -t --skip
set -e
fi fi