opendev/system-config
Code Issues Proposed changes

ATC listing script is importable

Browse Source 
* tools/atc/email_stats.py: Move procedural code out of the global
scope to make this file safely importable, and clean up a couple of
unused variables flake8 noticed in the newly importable main
codeblock.

Change-Id: I1a29c84e067eea875ba57a16196723f65f60ff01
This commit is contained in:
Jeremy Stanley 2014-06-24 19:07:49 +00:00
parent 1c608c8143
commit 876ba7a23b
1 changed files with 94 additions and 89 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tools/atc/email_stats.py Executable file → Normal file
View File

@ -28,7 +28,6 @@ import re
MAILTO_RE = re.compile('mailto:(.*)')
USERNAME_RE = re.compile('username:(.*)')
accounts = {}
class Account(object):
@ -39,17 +38,21 @@ class Account(object):
self.username = None
def get_account(num):
def get_account(accounts, num):
a = accounts.get(num)
if not a:
a = Account(num)
accounts[num] = a
return a
def main():
accounts = {}
for row in csv.reader(open('emails.csv')):
num, email, pw, external = row
num = int(num)
a = get_account(num)
a = get_account(accounts, num)
if email and email != '\\N' and email not in a.emails:
a.emails.append(email)
m = MAILTO_RE.match(external)
@ -67,7 +70,7 @@ for row in csv.reader(open('emails.csv')):
for row in csv.reader(open('accounts.csv')):
num = int(row[-1])
name = row[1]
a = get_account(num)
a = get_account(accounts, num)
a.full_name = name
username_accounts = {}
@ -78,7 +81,8 @@ atcs = []
optparser = optparse.OptionParser()
optparser.add_option(
'-p', '--project', default='nova', help='Project to generate stats for')
'-p', '--project', default='nova',
help='Project to generate stats for')
optparser.add_option(
'-o', '--output', default='out.csv', help='Output file')
options, args = optparser.parse_args()
@ -93,11 +97,9 @@ client.connect(
key_filename='/home/corvus/.ssh/id_rsa', username='CHANGME')
stdin, stdout, stderr = client.exec_command(
'gerrit query %s --all-approvals --format JSON' % QUERY)
changes = []
done = False
last_sortkey = ''
tz = datetime.tzinfo
start_date = datetime.datetime(2012, 9, 27, 0, 0, 0)
end_date = datetime.datetime(2013, 7, 30, 0, 0, 0)
@ -144,3 +146,6 @@ writer = csv.writer(open(options.output, 'w'))
for a in atcs:
writer.writerow([a.username, a.full_name] + a.emails)
print
if __name__ == "__main__":
main()