Rename backup to bup.

Naming it after what it installs. Also, split the target cronjob into
a define.

Change-Id: I73a4383f529c60bc35c60241dfc91508965d755e
Reviewed-on: https://review.openstack.org/10885
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins

modules/bup/manifests/init.pp

@@ -1,4 +1,4 @@
-class backup ($backup_user, $backup_server) {
+class bup {
   package { "bup":
     ensure => present
   }
@@ -20,10 +20,4 @@ class backup ($backup_user, $backup_server) {
 "
   }
 
-  cron { "bup-rs-ord":
-    user => root,
-    hour => "5",
-    minute => "37",
-    command => "tar -X /etc/bup-excludes -cPf - / | bup split -r $backup_user@$backup_server: -n root -q",
-  }
 }

modules/bup/manifests/site.pp

@@ -0,0 +1,8 @@
+define bup::site($backup_user, $backup_server) {
+  cron { "bup-$name":
+    user => root,
+    hour => "5",
+    minute => "37",
+    command => "tar -X /etc/bup-excludes -cPf - / | bup split -r $backup_user@$backup_server: -n root -q",
+  }
+}

modules/openstack_project/manifests/jenkins_dev.pp

@@ -2,7 +2,8 @@ class openstack_project::jenkins_dev {
   class { 'openstack_project::server':
     iptables_public_tcp_ports => [80, 443, 4155]
   } 
-  class { 'backup':
+  include bup
+  bup::site { 'rs-ord':
     backup_user => 'bup-jenkins-dev',
     backup_server => 'ci-backup-rs-ord.openstack.org'
   }