opendev/system-config
Code Issues Proposed changes

Fix line parsing in requirements check

Browse Source 
The requirements check script would strip one character from the end
of every line without a #, which was a problem if the last line
of the file had neither a # or a newline.

Change-Id: I89f1114695adc4de6ef95a96cffcf919c88a2ac8
This commit is contained in:
James E. Blair 2013-08-16 13:42:12 -07:00
parent 265f476629
commit 9f06bccfb8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/jenkins/files/slave_scripts/project-requirements-change.py
View File

@ -43,7 +43,8 @@ class RequirementsList(object):
if not os.path.exists(fn): if not os.path.exists(fn):
return return
for line in open(fn): for line in open(fn):
line = line[:line.find('#')] if '#' in line:
line = line[:line.find('#')]
line = line.strip() line = line.strip()
if (not line or if (not line or
line.startswith('http://tarballs.openstack.org/') or line.startswith('http://tarballs.openstack.org/') or