opendev/system-config
Code Issues Proposed changes

StoryBoard module bounces apache on update

Browse Source 
Apache doesn't reload python libs until a reboot, so
our strategy of reloading storyboard wasn't effective.
This removes the old storyboard-reload command and
replaces it with a straight http service restart.

Change-Id: I1f2fb736277c3ca39b513695e42ef4860267737f
This commit is contained in:
Michael Krotscheck 2014-06-06 13:30:26 -07:00
parent 855ed44997
commit a467ab5057
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
modules/storyboard/manifests/init.pp
View File

@ -69,7 +69,7 @@ class storyboard (
path => '/usr/local/bin:/usr/bin:/bin/', path => '/usr/local/bin:/usr/bin:/bin/',
refreshonly => true, refreshonly => true,
subscribe => Vcsrepo['/opt/storyboard'], subscribe => Vcsrepo['/opt/storyboard'],
notify => Exec['storyboard-reload'], notify => Service['httpd'],
require => Class['pip'], require => Class['pip'],
} }
@ -82,7 +82,7 @@ class storyboard (
owner => 'storyboard', owner => 'storyboard',
mode => '0400', mode => '0400',
content => template('storyboard/storyboard.conf.erb'), content => template('storyboard/storyboard.conf.erb'),
notify => Exec['storyboard-reload'], notify => Service['httpd'],
require => [ require => [
File['/etc/storyboard'], File['/etc/storyboard'],
User['storyboard'], User['storyboard'],
@ -151,12 +151,6 @@ class storyboard (
require => User['storyboard'], require => User['storyboard'],
} }
exec { 'storyboard-reload':
command => 'touch /usr/local/lib/python2.7/dist-packages/storyboard/api/app.wsgi',
path => '/usr/local/bin:/usr/bin:/bin/',
refreshonly => true,
}
# START storyboard-webclient # START storyboard-webclient
$tarball = 'storyboard-webclient.tar.gz' $tarball = 'storyboard-webclient.tar.gz'