From 4fa8d2dd393d3f119b93daddcb9686a1b55c7e8e Mon Sep 17 00:00:00 2001
From: Ian Wienand <iwienand@redhat.com>
Date: Tue, 6 Dec 2022 16:18:32 +1100
Subject: [PATCH] create-venv: make upgrade venv once per day

This was inspired by a similar change
I78a914f71cef687f09fcfee0f3f498b79d810f5d.  In the bootstrap-bridge
production, we are calling create-venv every time we fire off a set of
production jobs.  While it's good to keep the venv updated, it doesn't
need to happen hourly.

This writes the requirements to a file, and only installs it if the
template updates (i.e. if the venv is fresh, the dependencies updated
or we updated the daily timestamp).

Change-Id: I7a70b73fb907b923f47a2a0de72e21649c15e05f
---
 playbooks/roles/create-venv/tasks/main.yaml   | 49 +++++++++++++------
 .../templates/requirements-venv.txt           |  4 ++
 2 files changed, 37 insertions(+), 16 deletions(-)
 create mode 100644 playbooks/roles/create-venv/templates/requirements-venv.txt

diff --git a/playbooks/roles/create-venv/tasks/main.yaml b/playbooks/roles/create-venv/tasks/main.yaml
index 85350a248b..2fa84f6392 100644
--- a/playbooks/roles/create-venv/tasks/main.yaml
+++ b/playbooks/roles/create-venv/tasks/main.yaml
@@ -2,36 +2,53 @@
   assert:
     that: create_venv_path is defined
 
+- name: Ensure venv dir
+  file:
+    path: '{{ create_venv_path }}'
+    state: directory
+
 # Xenial's default pip will try to pull in packages that
 # aren't compatible with 3.5.  Cap them
-- name: Setup bionic era venv
+- name: Setup requirements for bionic
   when: ansible_distribution_version is version('16.04', '==')
-  pip:
-    name:
+  set_fact:
+    _venv_requirements:
       - pip<21
       - setuptools<51
-    state: latest
-    virtualenv: '{{ create_venv_path }}'
-    virtualenv_command: '/usr/bin/python3 -m venv'
 
 # Bionic's default pip will try to pull in packages that
 # aren't compatible with 3.6.  Cap them
-- name: Setup bionic era venv
+- name: Setup requirements for Bionic
   when: ansible_distribution_version is version('18.04', '==')
-  pip:
-    name:
+  set_fact:
+    _venv_requirements:
       - pip<22
       - setuptools<60
-    state: latest
-    virtualenv: '{{ create_venv_path }}'
-    virtualenv_command: '/usr/bin/python3 -m venv'
 
-- name: Setup later era venv
+- name: Setup requirements for later era
   when: ansible_distribution_version is version('20.04', '>=')
-  pip:
-    name:
+  set_fact:
+    _venv_requirements:
       - pip
       - setuptools
-    state: latest
+
+# This is used to timestamp the requirements-venv.txt file.  This
+# means we will run --upgrade on the venv once a day, but otherwise
+# leave it alone.
+- name: Get current day
+  shell: 'date +%Y-%m-%d'
+  register: _date
+
+- name: Write requirements
+  template:
+    src: requirements-venv.txt
+    dest: '{{ create_venv_path }}/requirements-venv.txt'
+  register: _venv_requirements_txt
+
+- name: Create or upgrade venv
+  when: _venv_requirements_txt.changed
+  pip:
+    requirements: '{{ create_venv_path }}/requirements-venv.txt'
+    extra_args: '--upgrade'
     virtualenv: '{{ create_venv_path }}'
     virtualenv_command: '/usr/bin/python3 -m venv'
diff --git a/playbooks/roles/create-venv/templates/requirements-venv.txt b/playbooks/roles/create-venv/templates/requirements-venv.txt
new file mode 100644
index 0000000000..ebc968a12e
--- /dev/null
+++ b/playbooks/roles/create-venv/templates/requirements-venv.txt
@@ -0,0 +1,4 @@
+# Update timestamp: {{ _date.stdout }}
+{% for r in _venv_requirements %}
+{{ r }}
+{% endfor %}