opendev/system-config
Code Issues Proposed changes

Additional puppet-lint formatting

Browse Source 
Change-Id: I6e5fa77a301eec30cff8e16bad33a91bfd95b13f
Signed-off-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-on: https://review.openstack.org/17176
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Jeremy Stanley <fungi@yuggoth.org>
Tested-by: Jenkins
This commit is contained in:
Paul Belanger 2012-11-29 19:40:14 -05:00 committed by Jenkins
parent 5c5033cbc7
commit a7ce7fd02e
5 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Rakefile
View File

@ -3,3 +3,6 @@ require 'puppetlabs_spec_helper/rake_tasks'
require 'puppet-lint/tasks/puppet-lint' require 'puppet-lint/tasks/puppet-lint'
PuppetLint.configuration.fail_on_warnings = true PuppetLint.configuration.fail_on_warnings = true
PuppetLint.configuration.send('disable_80chars') PuppetLint.configuration.send('disable_80chars')
# Disable check due to upstream bug: https://github.com/rodjek/puppet-lint/issues/170
PuppetLint.configuration.send('disable_class_parameter_defaults')

2
modules/etherpad_lite/manifests/init.pp
View File

@ -46,7 +46,7 @@ class etherpad_lite (
revision => $nodejs_version, revision => $nodejs_version,
require => [ require => [
Package['git'], Package['git'],
File["${base_install_dir}"], File[$base_install_dir],
], ],
} }

2
modules/gerrit/manifests/init.pp
View File

@ -65,7 +65,7 @@
# Set this to true to disable cron jobs and replication, # Set this to true to disable cron jobs and replication,
# which can interfere with testing. # which can interfere with testing.
# TODO: make more gerrit options configurable here # TODO: make more gerrit options configurable here
#
class gerrit( class gerrit(
$war = '', $war = '',
$mysql_password = '', $mysql_password = '',

4
modules/openstack_project/manifests/gerrit.pp
View File

@ -66,8 +66,8 @@ class openstack_project::gerrit (
vhost_name => $vhost_name, vhost_name => $vhost_name,
canonicalweburl => $canonicalweburl, canonicalweburl => $canonicalweburl,
# opinions # opinions
enable_melody => 'true', enable_melody => true,
melody_session => 'true', melody_session => true,
# passthrough # passthrough
ssl_cert_file => $ssl_cert_file, ssl_cert_file => $ssl_cert_file,
ssl_key_file => $ssl_key_file, ssl_key_file => $ssl_key_file,

14
modules/pip/manifests/init.pp
View File

@ -1,12 +1,12 @@
# Class: pip
#
class pip { class pip {
package { 'python-all-dev':
package { "python-all-dev":
ensure => present
}
package { "python-pip":
ensure => present, ensure => present,
require => Package[python-all-dev]
} }
package { 'python-pip':
ensure => present,
require => Package['python-all-dev'],
}
} }