From a8d35bb4bd4756e5e59e2b480a8cfafcafc7b68c Mon Sep 17 00:00:00 2001
From: Clark Boylan <clark.boylan@gmail.com>
Date: Fri, 14 Dec 2018 13:36:07 -0800
Subject: [PATCH] Copy pasta the debian base server bits, don't include them

The arm64 nodes install special kernels so we have a dedicated
base-server task list for them. To reduce duplication we were then
include_tasks: Debian.yaml but this seems to result in the ansible play
crashing there and continuing with the next play in the playbook as if
there were no failure/error.

This is concerning but to deal with this in the present lets copy pasta
the debian bits so things hopefully work again then go from there.

Logs of this occurring:

  2018-12-14 20:54:28,515 p=11685 u=root |  TASK [base-server : Install HWE kernel for arm64] ******************************
  2018-12-14 20:54:28,515 p=11685 u=root |  Friday 14 December 2018  20:54:28 +0000 (0:00:14.672)       0:08:06.479 *******
  2018-12-14 20:54:32,564 p=11685 u=root |  ok: [mirror01.london.linaro-london.openstack.org]
  2018-12-14 20:54:32,747 p=11685 u=root |  ok: [nb03.openstack.org]
  2018-12-14 20:54:32,843 p=11685 u=root |  ok: [mirror01.nrt1.arm64ci.openstack.org]
  2018-12-14 20:54:33,727 p=11685 u=root |  ok: [mirror01.cn1.linaro.openstack.org]
  2018-12-14 20:54:33,777 p=11685 u=root |  TASK [base-server : Include generic Debian tasks] ******************************
  2018-12-14 20:54:33,778 p=11685 u=root |  Friday 14 December 2018  20:54:33 +0000 (0:00:05.262)       0:08:11.741 *******
  2018-12-14 20:54:34,023 p=11685 u=root |  PLAY [Base: configure OpenStackSDK on bridge] **********************************
  2018-12-14 20:54:34,052 p=11685 u=root |  TASK [include_role : configure-openstacksdk] ***********************************

Change-Id: I20dbd5b4c768c967c82f786a7cb1d5261bf5b494
---
 .../tasks/Ubuntu.xenial.aarch64.yaml          | 47 ++++++++++++++++++-
 1 file changed, 45 insertions(+), 2 deletions(-)

diff --git a/playbooks/roles/base-server/tasks/Ubuntu.xenial.aarch64.yaml b/playbooks/roles/base-server/tasks/Ubuntu.xenial.aarch64.yaml
index 285f704246..51569ed10b 100644
--- a/playbooks/roles/base-server/tasks/Ubuntu.xenial.aarch64.yaml
+++ b/playbooks/roles/base-server/tasks/Ubuntu.xenial.aarch64.yaml
@@ -3,5 +3,48 @@
     name: linux-generic-hwe-16.04
     state: present
 
-- name: Include generic Debian tasks
-  include_tasks: Debian.yaml
+# This is copy pasta'd from Debian.yaml because
+#   include_tasks: Debian.yaml
+# Was here previously and resulted in this entire surrounding play
+# stopping/crashing and ansible continued with the next play in the
+# playbook as if nothing were wrong. This is concerning for a couple
+# reasons, why doesnt include_tasks work? and why does it crash ansible
+# without any reported failure.
+- name: Remove packages that make no sense for our servers
+  package:
+    name:
+      - whoopsie
+      - popularity-contest
+      - snapd
+      - lxd
+      - lxd-client
+    state: absent
+
+- name: Configure file limits
+  copy:
+    mode: 0644
+    src: debian_limits.conf
+    dest: /etc/security/limits.d/60-nofile-limit.conf
+
+- name: Custom rsyslog config to disable /dev/xconsole noise
+  copy:
+    mode: 0644
+    src: rsyslog.d_50-default.conf
+    dest: /etc/rsyslog.d/50-default.conf
+  notify: Restart rsyslog
+
+- name: Install apt-daily 10periodic file for unattended-upgrades
+  copy:
+     mode: 0444
+     src: 10periodic
+     dest: /etc/apt/apt.conf.d/10periodic
+     owner: root
+     group: root
+
+- name: Install 50unattended-upgrades file for unattended-upgrades
+  copy:
+     mode: 0444
+     src: 50unattended-upgrades
+     dest: /etc/apt/apt.conf.d/50unattended-upgrades
+     owner: root
+     group: root